All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: "Marco Scardovi" <scardracs@disroot.org>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
Date: Wed, 10 Jun 2026 19:54:00 +0200	[thread overview]
Message-ID: <e0c775f3-8eb7-41b8-a4c5-d5275a59a2eb@linux.dev> (raw)
In-Reply-To: <20260610152130.25892-1-scardracs@disroot.org>


On 6/10/26 17:21, Marco Scardovi wrote:
> Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> G16 G614PR laptop model.
>
> The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> correctly under various power profiles. Without these limits, the Asus
> Armoury driver cannot configure the correct power envelopes or enable custom
> fan curves, leading to suboptimal performance or noise management.
>
> This patch adds the corresponding DMI board name matching entry ("G614PR")
> under the power_limits table in asus-armoury.h, populating the AC and DC
> limits based on the platform's hardware specification.
Reviewed-by: Denis Benato <denis.benato@linux.dev>
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 692978b61959..5be34b6a92db 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 90,
> +				.ppt_pl2_sppt_min = 65,
> +				.ppt_pl2_sppt_def = 110,
> +				.ppt_pl2_sppt_max = 125,
> +				.ppt_pl3_fppt_min = 65,
> +				.ppt_pl3_fppt_def = 110,
> +				.ppt_pl3_fppt_max = 125,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_tgp_min = 65,
> +				.nv_tgp_max = 115,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 65,
> +				.ppt_pl2_sppt_min = 25,
> +				.ppt_pl2_sppt_max = 65,
> +				.ppt_pl3_fppt_min = 35,
> +				.ppt_pl3_fppt_max = 75,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),

  reply	other threads:[~2026-06-10 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
2026-06-10 17:54 ` Denis Benato [this message]
2026-06-11 15:02 ` Ilpo Järvinen
2026-06-11 15:53   ` Marco Scardovi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0c775f3-8eb7-41b8-a4c5-d5275a59a2eb@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=corentin.chary@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=scardracs@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.