All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-btrfs@vger.kernel.org
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
	David Sterba <dsterba@suse.com>, Boris Burkov <boris@bur.io>,
	Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v7 03/27] btrfs: zoned: fix possible race for reserved_active_zones
Date: Tue, 17 Nov 2026 13:09:44 -0800	[thread overview]
Message-ID: <e0cfda55-eb33-471d-9db5-38f4ef5d540c@kernel.org> (raw)
In-Reply-To: <20261117185850.4128157-4-johannes.thumshirn@wdc.com>

On 11/17/26 10:58, Johannes Thumshirn wrote:
> In call_zone_finish() the counter for reserved active zones is
> incremented without holding the per filesystem zone_active_bgs_lock
> potentially leading to a race for the active zone count.
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Fixes: a7e1ac7bdc5a ("btrfs: zoned: reserve zones for an active metadata/system block group")
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>



-- 
Damien Le Moal
Western Digital Research

      parent reply	other threads:[~2026-11-17 21:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:58 [PATCH v7 00/27] btrfs: zoned: fixes for generic/747 Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 05/27] btrfs: zoned: skip the append only metadata writeback path for conventional block groups Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 06/27] btrfs: zoned: never activate conventional metadata " Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 07/27] btrfs: zoned: use the regular allocator for " Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 08/27] btrfs: zoned: only take the metadata IO lock for append only " Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 09/27] btrfs: zoned: allow restricting the dev extent search to a zone type Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 10/27] btrfs: zoned: prefer conventional zones for metadata chunks Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 11/27] btrfs: zoned: use plain mutex lock in check_bg_is_active Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 20/27] btrfs: zoned: prepare reserving the data relocation block group at runtime Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 21/27] btrfs: zoned: promote reset data block groups to the relocation target Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 22/27] btrfs: zoned: return finished relocation block groups to the data space_info Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 23/27] btrfs: zoned: reuse block groups emptied by reclaim as relocation target Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 24/27] btrfs: add btrfs_bg_type_to_num_stripes Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 25/27] btrfs: zoned: keep a zone free for relocation when allocating data chunks Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 26/27] btrfs: zoned: don't count the relocation zone reserve as available in statfs Johannes Thumshirn
2026-11-17 18:58 ` [PATCH v7 27/27] btrfs: zoned: provide zoned specific reclaim sweep Johannes Thumshirn
     [not found] ` <20261117185850.4128157-2-johannes.thumshirn@wdc.com>
2026-11-17 21:07   ` [PATCH v7 01/27] btrfs: zoned: don't wait for a zone finish after a filesystem error Damien Le Moal
     [not found] ` <20261117185850.4128157-3-johannes.thumshirn@wdc.com>
2026-11-17 21:08   ` [PATCH v7 02/27] btrfs: zoned: reject dev-replace onto a target with different zone types Damien Le Moal
     [not found] ` <20261117185850.4128157-4-johannes.thumshirn@wdc.com>
2026-11-17 21:09   ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0cfda55-eb33-471d-9db5-38f4ef5d540c@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=boris@bur.io \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.