Re: [PATCH v2 net-next 2/3] inet: ping: remove ping_hash()

[Yue Haibing <yuehaibing@huawei.com>]

On 2025/8/29 14:57, Eric Dumazet wrote:
> On Thu, Aug 28, 2025 at 11:47 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>>
>> On 2025/8/29 0:41, Eric Dumazet wrote:
>>> There is no point in keeping ping_hash().
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>>> Reviewed-by: David Ahern <dsahern@kernel.org>
>>> ---
>>>  net/ipv4/ping.c | 10 ----------
>>>  net/ipv6/ping.c |  1 -
>>>  2 files changed, 11 deletions(-)
>>>
>>> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
>>> index 74a0beddfcc41d8ba17792a11a9d027c9d590bac..75e1b0f5c697653e79166fde5f312f46b471344a 100644
>>> --- a/net/ipv4/ping.c
>>> +++ b/net/ipv4/ping.c
>>> @@ -67,7 +67,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask)
>>>       pr_debug("hash(%u) = %u\n", num, res);
>>>       return res;
>>>  }
>>> -EXPORT_SYMBOL_GPL(ping_hash);
>>
>> The declaration should also be removed
>>
>> include/net/ping.h:58:void ping_unhash(struct sock *sk);
> 
> Right, but you probably meant

Sure，I have a copy_paste mistake.
> 
> include/net/ping.h:57:int ping_hash(struct sock *sk);