From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: small semaphore fix
Date: Fri, 02 Sep 2011 09:56:31 +0100 [thread overview]
Message-ID: <e0d58a$1abvhj@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20110901195111.0b338102@bwidawsk.net>
On Thu, 1 Sep 2011 19:51:11 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Thu, 01 Sep 2011 11:03:07 -0700
> Eric Anholt <eric@anholt.net> wrote:
>
> > On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky <ben@bwidawsk.net>
> > wrote:
> > > Assertion + unsigned helps catch potential issues.
> > >
> > > From the docs it is hard to tell if the global GTT flag is actually
> > > needed, but it shouldn't hurt.
> >
> > We're updating a register, not the GTT, so I don't see why the flag
> > would be relevant.
>
> The patch is as (ir)relevant as without it which implies PPGTT. The
> reason it was there is in another branch I was planning to implement
> memory based semaphores.
Memory based semaphores required working ppgtt, afaict.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-09-02 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 19:47 [PATCH] drm/i915: small semaphore fix Ben Widawsky
2011-09-01 18:03 ` Eric Anholt
2011-09-02 2:51 ` Ben Widawsky
2011-09-02 8:56 ` Chris Wilson [this message]
2011-09-02 14:18 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$1abvhj@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.