From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps Date: Tue, 29 Nov 2011 13:05:03 +0000 Message-ID: References: <1322571305-1939-1-git-send-email-eugeni.dodonov@intel.com> <1322571305-1939-2-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B0B379EFA6 for ; Tue, 29 Nov 2011 05:05:23 -0800 (PST) In-Reply-To: <1322571305-1939-2-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Tue, 29 Nov 2011 10:55:05 -0200, Eugeni Dodonov wrote: > This allows to enable/disable rps and rc6 from userspace. This is > necessary for to have predictable results from hardware counters, and also > to provide a finer granularity over power control from userspace. Reading registers and counters is handled with i915_forcewake_user. So the question is what benefit does htis give over module reload. It looks far riskier... -Chris -- Chris Wilson, Intel Open Source Technology Centre