From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/43] drm/i915: introduce a vtable for gpu core functions Date: Wed, 14 Dec 2011 15:06:34 +0000 Message-ID: References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-9-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 46E689E8AF for ; Wed, 14 Dec 2011 07:06:58 -0800 (PST) In-Reply-To: <1323867460-5486-9-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Dec 2011 13:57:06 +0100, Daniel Vetter wrote: > ... like for forcewake, which protects everything _but_ display. > Expect more things (like gtt abstractions, rings, inter-ring sync) > to come. The only thing that looks odd is the layout in drm_i915_private is a little haphazard. Otherwise, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre