From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/vgem: properly implement mmap Date: Wed, 08 Feb 2012 23:36:22 +0000 Message-ID: References: <1328743171-13750-1-git-send-email-ben@bwidawsk.net> <1328743171-13750-6-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 538479E76E for ; Wed, 8 Feb 2012 15:36:29 -0800 (PST) In-Reply-To: <1328743171-13750-6-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Ben Widawsky List-Id: dri-devel@lists.freedesktop.org On Thu, 9 Feb 2012 00:19:31 +0100, Ben Widawsky wrote: > Mostly copied from i915 gtt mmaps, this will properly fault in pages as > the user tries to use them. The only thing of note are that no > prefaulting occurs, so perhaps some kind of madvise will happen later if > needed. What's the goal here? Why not copy the simpler (from the driver perspective) CPU mmaps? I presume that this will be required for dmabuf in some form? -Chris -- Chris Wilson, Intel Open Source Technology Centre