From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>, Benson Leung <bleung@chromium.org>
Cc: keithp@keithp.com, airlied@linux.ie, djkurtz@chromium.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix single msg gmbus_xfers writes
Date: Mon, 13 Feb 2012 21:49:35 +0000 [thread overview]
Message-ID: <e0d58a$38gbj5@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20120213203838.GM5301@phenom.ffwll.local>
On Mon, 13 Feb 2012 21:38:38 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> This here looks like just a white-space change. But your commit message
> sounds like it's not jsut write's that are affected by this issue and need
> to be fixed. Can you please clear up this for easily confused me?
It makes the write path similar to the read path. I admit to overlooking
the single write message as everything I saw was always a write followed
by a read. The patch looks correct, but I need to stare at it a bit more
before I r-b.
However, the outstanding issue is that we need to separate the gmbus
i2c adapter from the gpio i2c adapter in order for the pairing to work
with the expectations of the i2c core.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-13 21:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 20:03 [PATCH] drm/i915: Fix single msg gmbus_xfers writes Benson Leung
2012-02-13 20:38 ` Daniel Vetter
2012-02-13 21:49 ` Chris Wilson [this message]
2012-02-13 22:26 ` Daniel Vetter
2012-02-13 22:26 ` Daniel Vetter
2012-02-14 9:35 ` Chris Wilson
2012-02-14 9:35 ` Chris Wilson
2012-02-15 10:48 ` Daniel Vetter
2012-02-20 11:22 ` Daniel Kurtz
2012-02-20 13:30 ` Daniel Vetter
2012-02-20 13:30 ` Daniel Vetter
2012-02-29 19:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$38gbj5@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=bleung@chromium.org \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.