From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: rename existing overlay support to "legacy" Date: Tue, 07 Jun 2011 21:59:55 +0100 Message-ID: References: <1307477262-8242-1-git-send-email-jbarnes@virtuousgeek.org> <1307477262-8242-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1307477262-8242-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 7 Jun 2011 13:07:41 -0700, Jesse Barnes wrote: > The old overlay block has all sorts of quirks and is very different than > ILK+ video sprites. So rename it to legacy to make that clear and clash > less with core overlay support. > > Signed-off-by: Jesse Barnes > --- > @@ -191,7 +191,7 @@ struct drm_i915_error_state { > u32 cache_level:2; > } *active_bo, *pinned_bo; > u32 active_bo_count, pinned_bo_count; > - struct intel_overlay_error_state *overlay; > + struct intel_legacy_overlay_error_state *overlay; We need to change the name here as well, unless you have some differently name error struct up your sleeve. struct intel_sprite_error_state? > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 3cfc391..d73e622 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -161,7 +161,7 @@ struct intel_crtc { > bool busy; /* is scanout buffer being updated frequently? */ > struct timer_list idle_timer; > bool lowfreq_avail; > - struct intel_overlay *overlay; > + struct intel_legacy_overlay *overlay; > struct intel_unpin_work *unpin_work; > int fdi_lanes; And here. Give the old code longer names, we don't want to be touching it ever again. ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre