From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: more forcewake lock error info Date: Wed, 22 Jun 2011 18:15:40 +0100 Message-ID: References: <1308761701-1751-1-git-send-email-ben@bwidawsk.net> <1308761701-1751-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0699B9E7B1 for ; Wed, 22 Jun 2011 10:15:44 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Alexander Zhaunerchyk List-Id: intel-gfx@lists.freedesktop.org On Wed, 22 Jun 2011 10:07:50 -0700, Ben Widawsky wrote: > On Wed, Jun 22, 2011 at 10:00 AM, Chris Wilson wrote: > > > On Wed, 22 Jun 2011 09:55:00 -0700, Ben Widawsky wrote: > > > Get some more useful info for debugging backtraces on forcewake > > > problems. Appropriate debug flags will be required for the drm module. > > > > Wouldn't it be neater to pass the reg down to > > gen6_gt_force_wake_get() so that we only have a single debug message and > > not an additional one for every inlined read/write? > > -Chris > > > > Urg... having some trouble with my email right now, so you have to deal with > my gmail/webmail... > > 1. Yes, but I was lazy. > 2. People call force_wake_get() without actually specifying a register, so I > didn't want to enforce people entering bogus info on those calls. We could always go for the traditional file:line automagic macros... But we already have that from the stacktrace if people are good enough to provide symbols. -Chris -- Chris Wilson, Intel Open Source Technology Centre