From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: Deep color support and bug fixes Date: Fri, 24 Jun 2011 11:24:08 +0100 Message-ID: References: <1305136090-5858-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 05B99A0955 for ; Fri, 24 Jun 2011 03:24:10 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 24 Jun 2011 10:32:16 +0100, Chris Wilson wrote: > So here goes -depth 30... So other than a couple of rendering paths where we write 8bpc data into the depth-30 fb (go flash, go!), X looks good. Textured XVideo should just work, GLX doesn't advertise a 10-bpc visual or fbconfig, so will only work if we can use a render copy for copy-swaps. However, I did need to: diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 9236965..ef4f29c 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -560,7 +560,9 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) mode_changed = true; } else if (set->fb == NULL) { mode_changed = true; - } else + } else if (set->fb->depth != set->crtc->fb->depth) + mode_changed = true; + else fb_changed = true; } for the kernel to spot the mode switch when starting X. Lack of logging ftl. ;-) For confirmation: PIPEACONF: 0xc0000020 (enabled, active, 10bpc) TRANSACONF: 0xc0000020 (enable, active) FDI_RXA_CTL: 0xb0192050 (enable, train pattern not train, port width X4, 10bpc,link_reverse_strap_overwrite no, dmi_link_reverse no, FDI PLL enable,FS ecc disable, FE ecc disable, FS err report disable, FE err report disable,scrambing enable, enhanced framing enable, PCDClk) Tested-by: Chris Wilson But for my review by, I want to see some logging and validation ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre