From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tvVnN1fxLzDqQH for ; Fri, 6 Jan 2017 01:44:23 +1100 (AEDT) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id v05Eg8No103153 for ; Thu, 5 Jan 2017 09:44:20 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 27smdxkgxv-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 05 Jan 2017 09:44:20 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Jan 2017 14:44:18 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4FEA6219005F for ; Thu, 5 Jan 2017 14:43:24 +0000 (GMT) Subject: Re: [RESEND] cxl: Force psl data-cache flush during device shutdown To: Vaibhav Jain , linuxppc-dev@lists.ozlabs.org References: <20170104061852.18512-1-vaibhav@linux.vnet.ibm.com> Cc: Philippe Bergheaud , frederic.barrat@fr.ibm.com, Ian Munsie , Andrew Donnellan , Gregory Kurz , Christophe Lombard From: Frederic Barrat Date: Thu, 5 Jan 2017 15:44:12 +0100 MIME-Version: 1.0 In-Reply-To: <20170104061852.18512-1-vaibhav@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Message-Id: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 04/01/2017 à 07:18, Vaibhav Jain a écrit : > This change adds a force psl data cache flush during device shutdown > callback. This should reduce a possibility of psl holding a dirty > cache line while the CAPP is being reinitialized, which may result in > a UE [load/store] machine check error. > > Signed-off-by: Vaibhav Jain > --- Looks good to me, thanks! Acked-by: Frederic Barrat > Resend: Fixed the author ident. > --- > drivers/misc/cxl/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 80a87ab..73432e7 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -1610,6 +1610,9 @@ static void cxl_pci_remove_adapter(struct cxl *adapter) > cxl_sysfs_adapter_remove(adapter); > cxl_debugfs_adapter_remove(adapter); > > + /* Flush adapter datacache as its about to be removed */ > + cxl_data_cache_flush(adapter); > + > cxl_deconfigure_adapter(adapter); > > device_unregister(&adapter->dev); >