Re: [Buildroot] [PATCH v2 1/1] package/piglit: bump version

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Bernd,

Thanks for the updated patch.

On 28/12/2025 13:43, Bernd Kuhls wrote:
> Disabled vulkan tests added by upstream commit:
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
> 
> Added X11-related configure options due to upstream commit:
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/d958b70d1fc5c2ee039363d862b14ca498a50e82
> 
> Added configure options to fix build errors without libdrm and with
> libegl/libgles enabled but without X11.
> These build errors were not seen before due to other build errors
> unfixed since the bump of python3 to 3.10 with buildroot commit
> 25b1fc2898d68ddf2674b14c738045875fc5a2dc:
> https://patchwork.ozlabs.org/project/buildroot/patch/20230723074303.603364-1-bernd@kuhls.net/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v2: added more build fixes (Julien)
>     bumped version to current HEAD
[...]
> diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
> index 4d17405d10..360bddd40e 100644
> --- a/package/piglit/piglit.mk
> +++ b/package/piglit/piglit.mk
> @@ -4,7 +4,7 @@
>  #
>  
> ################################################################################
> 
> -PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
> +PIGLIT_VERSION = 62d499d63d2b8b29a67efd9d93ed9b6a94d4950e
>  PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
>  PIGLIT_SITE_METHOD = git
>  PIGLIT_LICENSE = MIT (code), \
> @@ -29,16 +29,27 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
>  PIGLIT_CONF_OPTS += \
>  	-DPIGLIT_USE_WAFFLE=ON \
>  	-DPIGLIT_BUILD_CL_TESTS=OFF \
> +	-DPIGLIT_BUILD_VK_TESTS=OFF \
>  	-DPIGLIT_BUILD_WGL_TESTS=OFF \
>  	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
> 
>  ifeq ($(BR2_PACKAGE_XORG7),y)
>  # libxcb for xcb-dri2
> +PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=ON
>  PIGLIT_DEPENDENCIES += \
>  	xlib_libX11 \
>  	xlib_libXext \
>  	xorgproto \
>  	$(if $(BR2_PACKAGE_LIBXCB),libxcb)
> +else
> +PIGLIT_CONF_OPTS += -DPIGLIT_USE_X11=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_HAS_LIBDRM),y)

Here, the "utils/check-symbols" script reports the error:
package/piglit/piglit.mk:48: BR2_PACKAGE_HAS_LIBDRM referenced but not 
defined

I believe you meant "BR2_PACKAGE_LIBDRM".

Also, fixing this symbol name alone does not seem sufficient.
When testing with the following commands:

cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_PIGLIT=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SOFTPIPE=y
BR2_PACKAGE_MESA3D_OPENGL_EGL=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_WESTON=y
BR2_PACKAGE_PYTHON3=y
EOF
make olddefconfig
make piglit

The piglit meson configuration fails with error:

CMake Error at CMakeLists.txt:271 (message):
   PIGLIT_BUILD_DMA_BUF_TESTS require libdrm, gbm_bo_map(), 
libdrm>=2.4.98 and
   xcb-dri2

So maybe this line should rather be:

ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_LIBXCB),yy)

> +PIGLIT_DEPENDENCIES += libdrm
> +PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=ON
> +else
> +PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_DMA_BUF_TESTS=OFF
>  endif
> 
>  ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
> @@ -54,7 +65,7 @@ else
>  PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLX_TESTS=OFF
>  endif
> 
> -ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy)
> +ifeq 
> ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yyy)
>  PIGLIT_DEPENDENCIES += libegl
>  PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_GLES1_TESTS=ON \
>  	-DPIGLIT_BUILD_GLES2_TESTS=ON \
> --
> 2.47.3

Could you confirm and send an updated patch, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot