From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lars Rask <lars.rask@axis.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH 1/2] drm/sitronix/st7571-spi: Add support for ST75156 controller
Date: Mon, 26 Oct 2026 08:24:26 +0100 [thread overview]
Message-ID: <e123e765-fdf7-418c-b8cf-e814a80c2488@kernel.org> (raw)
In-Reply-To: <20261026-dancing-beneficial-tuatara-d70263@quoll>
On 26/10/2026 08:23, Krzysztof Kozlowski wrote:
> On Thu, Oct 22, 2026 at 05:31:05PM +0200, Lars Rask wrote:
>> +
>> static int st7571_spi_probe(struct spi_device *spi)
>> {
>> struct st7571_device *st7571;
>> struct regmap *regmap;
>> + struct spi_device_data *spi_data;
>> +
>> + spi_data = devm_kzalloc(&spi->dev, sizeof(*spi_data), GFP_KERNEL);
>> + if (IS_ERR(spi_data))
>> + return dev_err_probe(&spi->dev, PTR_ERR(regmap),
>> + "Failed to initialize spi data\n");
>
> I do not see how you initialize spi data here, so this is just incorrect
> error message. Regardless, driver NEVER prints error messages for
> allocation.
>
... and you have there obvious build warning. Don't copy-paste code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-26 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 15:31 [PATCH 0/2] Add support for st75156 in st7571 display driver Lars Rask
2026-10-22 15:31 ` [PATCH 1/2] drm/sitronix/st7571-spi: Add support for ST75156 controller Lars Rask
2026-10-22 15:48 ` sashiko-bot
2026-10-23 9:46 ` kernel test robot
2026-10-26 7:23 ` Krzysztof Kozlowski
2026-10-26 7:24 ` Krzysztof Kozlowski [this message]
2026-10-22 15:31 ` [PATCH 2/2] dt-bindings: display: sitronix,st75156: add example for SPI Lars Rask
2026-10-22 15:48 ` sashiko-bot
2026-10-26 7:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e123e765-fdf7-418c-b8cf-e814a80c2488@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars.rask@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.