From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30729C25B0E for ; Wed, 17 Aug 2022 02:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238352AbiHQCtC (ORCPT ); Tue, 16 Aug 2022 22:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238334AbiHQCsz (ORCPT ); Tue, 16 Aug 2022 22:48:55 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9CD44506F; Tue, 16 Aug 2022 19:48:51 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M6snh2s7qzkWQG; Wed, 17 Aug 2022 10:45:28 +0800 (CST) Received: from kwepemm600010.china.huawei.com (7.193.23.86) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 10:48:49 +0800 Received: from [10.174.178.31] (10.174.178.31) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 10:48:48 +0800 Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio To: Gao Xiang CC: , , , , , References: <20220815034829.3940803-1-sunke32@huawei.com> From: Sun Ke Message-ID: Date: Wed, 17 Aug 2022 10:48:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.31] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org 在 2022/8/17 10:41, Gao Xiang 写道: > Hi Ke, > > On Wed, Aug 17, 2022 at 09:44:46AM +0800, Sun Ke wrote: >> >> >> 在 2022/8/16 13:16, Gao Xiang 写道: >>> On Mon, Aug 15, 2022 at 11:48:29AM +0800, Sun Ke wrote: >>>> If erofs_fscache_alloc_request fail and then goto out, it will return 0. >>>> it should return a negative error code instead of 0. >>>> >>>> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead") >>>> Signed-off-by: Sun Ke >>> >>> Minor, I tried to apply this patch by updating the patch title into >>> "erofs: fix error return code in erofs_fscache_{meta_,}read_folio" >>> >>> since the original patch title is too long. >> >> Should I send a v2 patch to update the title? > > I've already updated this by hand if you have no concern ;) > will push out to -next today... ;) Thanks, Sun Ke > > Thanks, > Gao Xiang > >> >> Thanks, >> Sun Ke >>> >>> Thanks, >>> Gao Xiang >>> . >>> > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6788C25B0E for ; Wed, 17 Aug 2022 02:49:34 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M6stP1nCNz3blw for ; Wed, 17 Aug 2022 12:49:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ozlabs.org; s=201707; t=1660704573; bh=yITaNThql62roBDZgcgbCrNqYiV4UEGUfAOYcYwM/IY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JPBK9hNhBFFk/I5ilhGHQJDoAx78o1ss8cHRp3dPsqtlPdd/jrUmdCMD8fRXMLMFt y5Xz/SbBRcRhr3EeUVSM1Cnd6utxZA+T0j5wS+706Jzi1wlDgORzYnRAMvtLysQ+2o ueTzcnifQKyV3C7GmQZ+EqjGE7QdSxRelaLlFkZ0ViGYgnHG3axv7PLnMtnRRvF8bK ijgjKNXOQ1NCI1Kf5l3+oY04J1/w5+KClR9J4+Wun4S+XhMS7YzMVhKPmq43gp6ZkQ vkmRLGfFegjl8IPuAmWiyDxbe5emEzeZET2E+VbCAiJJwErbQ3mXMbHoyRcVz/l7jj FmELeobaMTfKg== Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.187; helo=szxga01-in.huawei.com; envelope-from=sunke32@huawei.com; receiver=) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M6stD6Wf6z2xH2 for ; Wed, 17 Aug 2022 12:49:24 +1000 (AEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M6snh2s7qzkWQG; Wed, 17 Aug 2022 10:45:28 +0800 (CST) Received: from kwepemm600010.china.huawei.com (7.193.23.86) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 10:48:49 +0800 Received: from [10.174.178.31] (10.174.178.31) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 10:48:48 +0800 Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio To: Gao Xiang References: <20220815034829.3940803-1-sunke32@huawei.com> Message-ID: Date: Wed, 17 Aug 2022 10:48:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.31] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sun Ke via Linux-erofs Reply-To: Sun Ke Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org, yinxin.x@bytedance.com Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" 在 2022/8/17 10:41, Gao Xiang 写道: > Hi Ke, > > On Wed, Aug 17, 2022 at 09:44:46AM +0800, Sun Ke wrote: >> >> >> 在 2022/8/16 13:16, Gao Xiang 写道: >>> On Mon, Aug 15, 2022 at 11:48:29AM +0800, Sun Ke wrote: >>>> If erofs_fscache_alloc_request fail and then goto out, it will return 0. >>>> it should return a negative error code instead of 0. >>>> >>>> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead") >>>> Signed-off-by: Sun Ke >>> >>> Minor, I tried to apply this patch by updating the patch title into >>> "erofs: fix error return code in erofs_fscache_{meta_,}read_folio" >>> >>> since the original patch title is too long. >> >> Should I send a v2 patch to update the title? > > I've already updated this by hand if you have no concern ;) > will push out to -next today... ;) Thanks, Sun Ke > > Thanks, > Gao Xiang > >> >> Thanks, >> Sun Ke >>> >>> Thanks, >>> Gao Xiang >>> . >>> > . >