From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860D216C868; Wed, 24 Apr 2024 16:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713976560; cv=none; b=ctnFOeO3ye3UBeRVo9MAZbWIYoDs4IXRGaKbBhPRAJOBCL8OXGAwNoWtt0Hptm0wk3rc4jOagqc91zSVXV2O3A1+/9XKaPHLfpSL6McIpToE6PysjoKSM4nzh2wulCcddUtobIX4W3Q90KGJTad/YewtOs9rGNFAee1TSBEml10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713976560; c=relaxed/simple; bh=UlhmmvF4qokJRQpaGwr/z557sqx6SfWJMcb3qZplI3s=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=PMfWDBL6/CgVxjUKo9rT3yJbC34h557pA1aSL2UonKixnZOLv4qE7vpCBdw7wAdWSbUwbuY3HfFjjOv187pqmvMev9qMLwhbeq2gBRO3ISDSof/TLkV05+qFvXJlQ37TMYbzbbgRudw7wfKp3lCMidV+kiYxlaPxpW5aC2cS7b8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VPl0q61vXz6K5kn; Thu, 25 Apr 2024 00:33:31 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 8886E1406AE; Thu, 25 Apr 2024 00:35:54 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (7.191.163.213) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Apr 2024 17:35:54 +0100 Received: from lhrpeml500001.china.huawei.com ([7.191.163.213]) by lhrpeml500001.china.huawei.com ([7.191.163.213]) with mapi id 15.01.2507.035; Wed, 24 Apr 2024 17:35:54 +0100 From: Salil Mehta To: Marc Zyngier , Jonathan Cameron CC: Thomas Gleixner , Peter Zijlstra , "linux-pm@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "x86@kernel.org" , Russell King , "Rafael J . Wysocki" , "Miguel Luis" , James Morse , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Linuxarm , Ingo Molnar , Borislav Petkov , Dave Hansen , "justin.he@arm.com" , "jianyong.wu@arm.com" Subject: RE: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs Thread-Topic: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs Thread-Index: AQHakZivrv7wCN4TwkObtNOE7FjxL7F0DvwAgAGo+ICAAaE4AIAALFkAgAAgu/A= Date: Wed, 24 Apr 2024 16:35:54 +0000 Message-ID: References: <20240418135412.14730-1-Jonathan.Cameron@huawei.com> <20240418135412.14730-12-Jonathan.Cameron@huawei.com> <20240422114020.0000294f@Huawei.com> <87plugthim.wl-maz@kernel.org> <20240424135438.00001ffc@huawei.com> <86il06rd19.wl-maz@kernel.org> In-Reply-To: <86il06rd19.wl-maz@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 > From: Marc Zyngier > Sent: Wednesday, April 24, 2024 4:33 PM > To: Jonathan Cameron > Cc: Thomas Gleixner ; Peter Zijlstra > ; linux-pm@vger.kernel.org; > loongarch@lists.linux.dev; linux-acpi@vger.kernel.org; linux- > arch@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; kvmarm@lists.linux.dev; x86@kernel.org; > Russell King ; Rafael J . Wysocki > ; Miguel Luis ; James Morse > ; Salil Mehta ; Jean- > Philippe Brucker ; Catalin Marinas > ; Will Deacon ; Linuxarm > ; Ingo Molnar ; Borislav > Petkov ; Dave Hansen ; > justin.he@arm.com; jianyong.wu@arm.com > Subject: Re: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's > disabled but 'online capable' CPUs > =20 > On Wed, 24 Apr 2024 13:54:38 +0100, > Jonathan Cameron wrote: > > > > On Tue, 23 Apr 2024 13:01:21 +0100 > > Marc Zyngier wrote: > > > > > On Mon, 22 Apr 2024 11:40:20 +0100, > > > Jonathan Cameron wrote: > > > > > > > > On Thu, 18 Apr 2024 14:54:07 +0100 Jonathan Cameron > > > > wrote: > =20 > [...] > =20 > > > > > > > > > + /* > > > > > + * Capable but disabled CPUs can be brought online later. Wha= t about > > > > > + * the redistributor? ACPI doesn't want to say! > > > > > + * Virtual hotplug systems can use the MADT's "always-on" GIC= R entries. > > > > > + * Otherwise, prevent such CPUs from being brought online. > > > > > + */ > > > > > + if (!(gicc->flags & ACPI_MADT_ENABLED)) { > > > > > + pr_warn_once("CPU %u's redistributor is inaccessible: this C= PU can't be brought online\n", cpu); > > > > > + set_cpu_present(cpu, false); > > > > > + set_cpu_possible(cpu, false); (a digression) shouldn't we be clearing the enabled mask as well? set_cpu_enabled(cpu, false); Best regards Salil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47B36C4345F for ; Wed, 24 Apr 2024 16:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0V5Wf3PdJfWgK7RR2lk7sRptsREc8hJs87vrFOGWpHM=; b=TvUMZISsU2nb+T vsnbY7MGnkk6OJQQfAH2uMDlJc7oBkAbAiabUMlEGQb+JHWH8OMrzXA6J/+gDTpWoNPSAhAQMcabq m0TeFM8hgwM0xDf8uIJ5w7L2T9X8xwqMr2wCW+pzWZWPb3ztkQA7JDdvOSQpniRCX0mxLTo2KZYMj NUz+INk4VzKLy7Sk8KE4DTzswpRv0i0/n8Peh9gb/Bjixop9y9fEAZvN8XnTvGZYohxNvvyRej1Fp hLkqNQqh55+8wunB7ZGdVx9eFala+1ZtQhvg1Exct/vzbbbqKayxPoBcHqNP9K8c9EAy6suolrB7N ClcRwVlHmJ3Sxr2QwwUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzfbQ-00000004z6j-1qa8; Wed, 24 Apr 2024 16:36:12 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzfbL-00000004z2O-30Ir for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 16:36:10 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VPl0q61vXz6K5kn; Thu, 25 Apr 2024 00:33:31 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 8886E1406AE; Thu, 25 Apr 2024 00:35:54 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (7.191.163.213) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Apr 2024 17:35:54 +0100 Received: from lhrpeml500001.china.huawei.com ([7.191.163.213]) by lhrpeml500001.china.huawei.com ([7.191.163.213]) with mapi id 15.01.2507.035; Wed, 24 Apr 2024 17:35:54 +0100 From: Salil Mehta To: Marc Zyngier , Jonathan Cameron CC: Thomas Gleixner , Peter Zijlstra , "linux-pm@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "x86@kernel.org" , Russell King , "Rafael J . Wysocki" , "Miguel Luis" , James Morse , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Linuxarm , Ingo Molnar , Borislav Petkov , Dave Hansen , "justin.he@arm.com" , "jianyong.wu@arm.com" Subject: RE: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs Thread-Topic: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs Thread-Index: AQHakZivrv7wCN4TwkObtNOE7FjxL7F0DvwAgAGo+ICAAaE4AIAALFkAgAAgu/A= Date: Wed, 24 Apr 2024 16:35:54 +0000 Message-ID: References: <20240418135412.14730-1-Jonathan.Cameron@huawei.com> <20240418135412.14730-12-Jonathan.Cameron@huawei.com> <20240422114020.0000294f@Huawei.com> <87plugthim.wl-maz@kernel.org> <20240424135438.00001ffc@huawei.com> <86il06rd19.wl-maz@kernel.org> In-Reply-To: <86il06rd19.wl-maz@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.34.240] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_093608_134282_E8BED5A7 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Marc Zyngier > Sent: Wednesday, April 24, 2024 4:33 PM > To: Jonathan Cameron > Cc: Thomas Gleixner ; Peter Zijlstra > ; linux-pm@vger.kernel.org; > loongarch@lists.linux.dev; linux-acpi@vger.kernel.org; linux- > arch@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; kvmarm@lists.linux.dev; x86@kernel.org; > Russell King ; Rafael J . Wysocki > ; Miguel Luis ; James Morse > ; Salil Mehta ; Jean- > Philippe Brucker ; Catalin Marinas > ; Will Deacon ; Linuxarm > ; Ingo Molnar ; Borislav > Petkov ; Dave Hansen ; > justin.he@arm.com; jianyong.wu@arm.com > Subject: Re: [PATCH v7 11/16] irqchip/gic-v3: Add support for ACPI's > disabled but 'online capable' CPUs > > On Wed, 24 Apr 2024 13:54:38 +0100, > Jonathan Cameron wrote: > > > > On Tue, 23 Apr 2024 13:01:21 +0100 > > Marc Zyngier wrote: > > > > > On Mon, 22 Apr 2024 11:40:20 +0100, > > > Jonathan Cameron wrote: > > > > > > > > On Thu, 18 Apr 2024 14:54:07 +0100 Jonathan Cameron > > > > wrote: > > [...] > > > > > > > > > > + /* > > > > > + * Capable but disabled CPUs can be brought online later. What about > > > > > + * the redistributor? ACPI doesn't want to say! > > > > > + * Virtual hotplug systems can use the MADT's "always-on" GICR entries. > > > > > + * Otherwise, prevent such CPUs from being brought online. > > > > > + */ > > > > > + if (!(gicc->flags & ACPI_MADT_ENABLED)) { > > > > > + pr_warn_once("CPU %u's redistributor is inaccessible: this CPU can't be brought online\n", cpu); > > > > > + set_cpu_present(cpu, false); > > > > > + set_cpu_possible(cpu, false); (a digression) shouldn't we be clearing the enabled mask as well? set_cpu_enabled(cpu, false); Best regards Salil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel