From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B45C2C63777 for ; Tue, 17 Nov 2020 19:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 575672222C for ; Tue, 17 Nov 2020 19:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QsXPHKJv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730527AbgKQTw4 (ORCPT ); Tue, 17 Nov 2020 14:52:56 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:19339 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729022AbgKQTwz (ORCPT ); Tue, 17 Nov 2020 14:52:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605642775; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hnQE3V/VgsKShe0gpDn4RBB+Bf9jSoeX13bACRrVaWE=; b=QsXPHKJvy6bf3nRvpi+WVYtyQAPqZ/ehM/a4eQgGGoZIcQJV1197NN0aD9YdN9ejcNdTckV0 rNKdLiM1OGNNA9Agv3Z2pSgsqI9NAtUbjfViE0O2m92GM9Xy25CRtgeU9Z1grQsaJp3o+vxb SdekwFrDdnjNbr67LSRL13Wotg4= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5fb42a17d6e6336a4e1e4f01 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 17 Nov 2020 19:52:55 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 06648C43467; Tue, 17 Nov 2020 19:52:54 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 12D24C43460; Tue, 17 Nov 2020 19:52:52 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Nov 2020 11:52:52 -0800 From: abhinavk@codeaurora.org To: Wei Li Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Rajesh Yadav , Sravanthi Kollukuduru , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com Subject: Re: [PATCH] drm/msm: Fix error return code in msm_drm_init() In-Reply-To: <20201117023649.26657-1-liwei391@huawei.com> References: <20201117023649.26657-1-liwei391@huawei.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-11-16 18:36, Wei Li wrote: > When it fail to create crtc_event kthread, it just jump to > err_msm_uninit, > while the 'ret' is not updated. So assign the return code before that. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Reported-by: Hulk Robot > Signed-off-by: Wei Li Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c > b/drivers/gpu/drm/msm/msm_drv.c > index 49685571dc0e..37a373c5ced3 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -506,6 +506,7 @@ static int msm_drm_init(struct device *dev, struct > drm_driver *drv) > "crtc_event:%d", priv->event_thread[i].crtc_id); > if (IS_ERR(priv->event_thread[i].worker)) { > DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); > + ret = PTR_ERR(priv->event_thread[i].worker); > goto err_msm_uninit; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF57AC63697 for ; Tue, 17 Nov 2020 19:52:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EAB62222E for ; Tue, 17 Nov 2020 19:52:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QsXPHKJv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EAB62222E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8895289DD8; Tue, 17 Nov 2020 19:52:56 +0000 (UTC) Received: from z5.mailgun.us (z5.mailgun.us [104.130.96.5]) by gabe.freedesktop.org (Postfix) with ESMTPS id C69F46E067 for ; Tue, 17 Nov 2020 19:52:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605642775; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hnQE3V/VgsKShe0gpDn4RBB+Bf9jSoeX13bACRrVaWE=; b=QsXPHKJvy6bf3nRvpi+WVYtyQAPqZ/ehM/a4eQgGGoZIcQJV1197NN0aD9YdN9ejcNdTckV0 rNKdLiM1OGNNA9Agv3Z2pSgsqI9NAtUbjfViE0O2m92GM9Xy25CRtgeU9Z1grQsaJp3o+vxb SdekwFrDdnjNbr67LSRL13Wotg4= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fb42a178e090a8886c08ad7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 17 Nov 2020 19:52:55 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 094CCC43462; Tue, 17 Nov 2020 19:52:55 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 12D24C43460; Tue, 17 Nov 2020 19:52:52 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 17 Nov 2020 11:52:52 -0800 From: abhinavk@codeaurora.org To: Wei Li Subject: Re: [PATCH] drm/msm: Fix error return code in msm_drm_init() In-Reply-To: <20201117023649.26657-1-liwei391@huawei.com> References: <20201117023649.26657-1-liwei391@huawei.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Rajesh Yadav , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, guohanjun@huawei.com, Sean Paul , Sravanthi Kollukuduru Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-11-16 18:36, Wei Li wrote: > When it fail to create crtc_event kthread, it just jump to > err_msm_uninit, > while the 'ret' is not updated. So assign the return code before that. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Reported-by: Hulk Robot > Signed-off-by: Wei Li Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c > b/drivers/gpu/drm/msm/msm_drv.c > index 49685571dc0e..37a373c5ced3 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -506,6 +506,7 @@ static int msm_drm_init(struct device *dev, struct > drm_driver *drv) > "crtc_event:%d", priv->event_thread[i].crtc_id); > if (IS_ERR(priv->event_thread[i].worker)) { > DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); > + ret = PTR_ERR(priv->event_thread[i].worker); > goto err_msm_uninit; > } _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel