From: Jeff Layton <jlayton@kernel.org>
To: Scott Mayhew <smayhew@redhat.com>, mcgrof@kernel.org
Cc: kdevops@lists.linux.dev
Subject: Re: [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed
Date: Tue, 17 Oct 2023 11:45:47 -0400 [thread overview]
Message-ID: <e160eddbbb953557be1ff2845196b4afecda04bb.camel@kernel.org> (raw)
In-Reply-To: <20231017143344.430183-1-smayhew@redhat.com>
On Tue, 2023-10-17 at 10:33 -0400, Scott Mayhew wrote:
> Currently they get skipped because localhost isn't included in
> ansible-playbook --limit arg. This results in subsequent errors when
> parsing fstests results if the junitxml and/or junitparser modules
> aren't already installed.
>
> Fixes: e00143f6 ("fstests: add support for testing NFS")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> workflows/fstests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/workflows/fstests/Makefile b/workflows/fstests/Makefile
> index 370be411..e6346084 100644
> --- a/workflows/fstests/Makefile
> +++ b/workflows/fstests/Makefile
> @@ -137,7 +137,7 @@ DYNAMIC_RUNTIME_VARS += , "fstests_start_after_test": "$(START_AFTER)"
> endif
>
> fstests:
> - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \
> + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \
> -f 30 -i hosts playbooks/fstests.yml --skip-tags run_tests,copy_results $(LIMIT_HOSTS)
>
> fstests-kdevops-setup: $(KDEVOPS_EXTRA_VARS)
LGTM. Merged into master.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-10-17 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:33 [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed Scott Mayhew
2023-10-17 15:45 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e160eddbbb953557be1ff2845196b4afecda04bb.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.