From: Greg Felix <gregfelixlkml@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: [PATCH] ata_piix.c: check PCI sub-class code before AHCI disabling
Date: Fri, 4 Mar 2005 17:04:55 -0700 [thread overview]
Message-ID: <e16ac85e050304160467045421@mail.gmail.com> (raw)
This patch adds functionality to check the PCI sub-class code of an
AHCI capable device before disabling AHCI. It fixes a bug where an
ICH7 sata controller is being setup by the BIOS as sub-class 1 (ide)
and the AHCI control registers weren't being initialized, thus causing
an IO error in piix_disable_ahci().
Thanks,
Greg Felix
Signed-off-by: Gregory Felix <greg.felix@gmail.com>
--- drivers/scsi/ata_piix.c.orig 2005-03-04 15:25:48.966846795 -0700
+++ drivers/scsi/ata_piix.c 2005-03-04 15:27:55.942404850 -0700
@@ -38,6 +38,7 @@ enum {
PIIX_IOCFG = 0x54, /* IDE I/O configuration register */
ICH5_PMR = 0x90, /* port mapping register */
ICH5_PCS = 0x92, /* port control and status */
+ PIIX_SCC = 0x0A, /* sub-class code register */
PIIX_FLAG_AHCI = (1 << 28), /* AHCI possible */
PIIX_FLAG_CHECKINTR = (1 << 29), /* make sure PCI INTx enabled */
@@ -61,6 +62,8 @@ enum {
ich6_sata = 3,
ich6_sata_rm = 4,
ich7_sata = 5,
+
+ PIIX_AHCI_DEVICE = 6,
};
static int piix_init_one (struct pci_dev *pdev,
@@ -609,9 +612,13 @@ static int piix_init_one (struct pci_dev
port_info[1] = NULL;
if (port_info[0]->host_flags & PIIX_FLAG_AHCI) {
- int rc = piix_disable_ahci(pdev);
- if (rc)
- return rc;
+ u8 tmp;
+ pci_read_config_byte(pdev, PIIX_SCC, &tmp);
+ if (tmp == PIIX_AHCI_DEVICE) {
+ int rc = piix_disable_ahci(pdev);
+ if (rc)
+ return rc;
+ }
}
if (port_info[0]->host_flags & PIIX_FLAG_COMBINED) {
next reply other threads:[~2005-03-05 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 0:04 Greg Felix [this message]
2005-07-28 19:56 ` [PATCH] ata_piix.c: check PCI sub-class code before AHCI disabling Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-05-16 21:31 Christopher Allen Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16ac85e050304160467045421@mail.gmail.com \
--to=gregfelixlkml@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.