From: Holger Dengler <dengler@linux.ibm.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, x86@kernel.org,
Harald Freudenberger <freude@linux.ibm.com>
Subject: Re: [PATCH 1/3] crypto: s390 - Remove des and des3_ede code
Date: Thu, 9 Apr 2026 10:22:11 +0200 [thread overview]
Message-ID: <e1767c51-0bfc-45fa-896e-ac2de0268828@linux.ibm.com> (raw)
In-Reply-To: <d5fb24534a56017e622ef15272eb2f0cfc6d6de6.camel@physik.fu-berlin.de>
Hi Adrian,
On 09/04/2026 09:29, John Paul Adrian Glaubitz wrote:
> On Thu, 2026-04-09 at 09:08 +0200, Holger Dengler wrote:
>> On 26/03/2026 21:12, Eric Biggers wrote:
>>> Since DES and Triple DES are obsolete, there is very little point in
>>> maintining architecture-optimized code for them. Remove it.
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
>>
>> Reviewed-by: Holger Dengler <dengler@linux.ibm.com>
>
> Wouldn't it actually make sense to keep the old crypto code so we get
> additional coverage for QEMU's emulation of crypto instructions?
For qemu test coverage on s390, I would prefer the libica [1] test cases,
which covers mostly all functions codes of the CPACF instructions.
If you want to use the kernel code for testing in addition, you may stay with
a kernel version before the code removal.
[1] https://github.com/opencryptoki/libica
--
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com
next prev parent reply other threads:[~2026-04-09 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 20:12 [PATCH 0/3] crypto: Remove arch-optimized des and des3_ede code Eric Biggers
2026-03-26 20:12 ` [PATCH 1/3] crypto: s390 - Remove " Eric Biggers
2026-03-27 8:52 ` Holger Dengler
2026-03-27 17:32 ` Eric Biggers
2026-04-09 11:02 ` Harald Freudenberger
2026-04-09 7:08 ` Holger Dengler
2026-04-09 7:29 ` John Paul Adrian Glaubitz
2026-04-09 8:22 ` Holger Dengler [this message]
2026-04-09 17:48 ` Eric Biggers
2026-03-26 20:12 ` [PATCH 2/3] crypto: sparc " Eric Biggers
2026-03-26 20:12 ` [PATCH 3/3] crypto: x86 " Eric Biggers
2026-03-26 20:20 ` [PATCH 0/3] crypto: Remove arch-optimized " John Paul Adrian Glaubitz
2026-03-26 20:27 ` Eric Biggers
2026-03-26 21:07 ` Eric Biggers
2026-03-27 9:59 ` Simon Richter
2026-03-27 17:24 ` Eric Biggers
2026-04-09 12:46 ` Ard Biesheuvel
2026-04-08 13:35 ` Harald Freudenberger
2026-04-08 13:43 ` John Paul Adrian Glaubitz
2026-04-03 1:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1767c51-0bfc-45fa-896e-ac2de0268828@linux.ibm.com \
--to=dengler@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=freude@linux.ibm.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.