From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from penguin.netx4.com (embeddededge.com [209.113.146.155]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 3F80D68663 for ; Wed, 2 Nov 2005 03:50:39 +1100 (EST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Dan Malek Date: Tue, 1 Nov 2005 11:08:30 -0500 To: hs@dexn.de Cc: "linuxppc-dev@ozlabs.org list" Subject: Re: [PATCH] ppc32: Fix SCC Uart write problem after 2. open() List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Nov 1, 2005, at 2:17 AM, Heiko Schocher wrote: > The following Patch will fix this problem. This is wrong. We should never have to reinitialize the buffer descriptors (which I see the driver does in some cases) and we certainly should never have to reinitialize the SCC or SMC peripherals like this. Once the driver has initialized the SCC or SMC and set up the buffer descriptors during kernel start up, it should never be done again. The only thing we should do is stop/start the transmitter or receiver, and they should continue operation with the next buffer descriptor in the ring. This patch just covers up a driver bug, find and fix the real bug. Thanks. -- Dan