From: Eric Farman <farman@linux.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: pasic@linux.ibm.com, borntraeger@linux.ibm.com, thuth@redhat.com,
qemu-s390x@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/s390x/ccw-device: Fix memory leak in loadparm setter
Date: Wed, 25 Jun 2025 09:15:57 -0400 [thread overview]
Message-ID: <e1c8da1cf78e911fcdf1855a6c381dbe96048c0a.camel@linux.ibm.com> (raw)
In-Reply-To: <20250625082751.24896-1-kwolf@redhat.com>
On Wed, 2025-06-25 at 10:27 +0200, Kevin Wolf wrote:
> Commit bdf12f2a fixed the setter for the "loadparm" machine property,
> which gets a string from a visitor, passes it to s390_ipl_fmt_loadparm()
> and then forgot to free it. It left another instance of the same problem
> unfixed in the "loadparm" device property. Fix it.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/s390x/ccw-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Farman <farman@linux.ibm.com>
next prev parent reply other threads:[~2025-06-25 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 8:27 [PATCH] hw/s390x/ccw-device: Fix memory leak in loadparm setter Kevin Wolf
2025-06-25 13:15 ` Eric Farman [this message]
2025-06-25 13:36 ` Thomas Huth
2025-06-25 22:19 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c8da1cf78e911fcdf1855a6c381dbe96048c0a.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=kwolf@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.