From: Gerd Rausch <gerd.rausch@oracle.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/addr: Refresh neighbour entries upon "rdma_resolve_addr"
Date: Thu, 16 Jun 2022 08:50:31 -0700 [thread overview]
Message-ID: <e1ec1bce637359d798a4c614e4efa94a140324d5.camel@oracle.com> (raw)
In-Reply-To: <YqrW0s7FII1FoBwb@unreal>
On Thu, 2022-06-16 at 10:08 +0300, Leon Romanovsky wrote:
> On Mon, Jun 06, 2022 at 12:38:36PM -0700, Gerd Rausch wrote:
> > Unlike with IPv[46], where "ip_finish_output2" triggers
> > a refresh of STALE neighbour entries via "neigh_output",
> > "rdma_resolve_addr" never triggers an update.
> >
> > If a wrong STALE entry ever enters the cache, it'll remain
> > wrong forever (unless refreshed via TCP/IP, or otherwise).
> >
> > Let the cache inconsistency resolve itself by triggering
> > an update from "rdma_resolve_addr".
> >
> > Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com>
> > ---
> > drivers/infiniband/core/addr.c | 40 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 40 insertions(+)
>
> Gerd,
>
> Do you plan to resubmit the patch?
> There is a complain from kbuild robot.
>
>
Hi Leon,
The kbuild robot complained about a __be32 passed as u32.
I'll simply add a "(__force u32)" cast as is done in other places.
I didn't want to make a lot of noise by re-submitting for such a simple
change, but I can certainly re-submit, and will do so.
Thanks,
Gerd
prev parent reply other threads:[~2022-06-16 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 19:38 [PATCH 1/1] RDMA/addr: Refresh neighbour entries upon "rdma_resolve_addr" Gerd Rausch
2022-06-07 8:21 ` kernel test robot
2022-06-16 7:08 ` Leon Romanovsky
2022-06-16 15:50 ` Gerd Rausch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ec1bce637359d798a4c614e4efa94a140324d5.camel@oracle.com \
--to=gerd.rausch@oracle.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.