Re: [PATCH net v3 1/5] net: phy: split phy_probe() error paths

[Xuanqiang Luo <xuanqiang.luo@linux.dev>]

在 2026/8/19 21:35, Andrew Lunn 写道:
> On Wed, Aug 19, 2026 at 02:02:32PM +0800, Xuanqiang Luo wrote:
>> -out:
>> +out_unreg_led_triggers:
>> +	if (!phydev->is_on_sfp_module)
>> +		phy_led_triggers_unregister(phydev);
>> +
>> +out_sfp_release:
>>   	sfp_bus_del_upstream(phydev->sfp_bus);
>>   	phydev->sfp_bus = NULL;
>>   
>>   	phy_cleanup_ports(phydev);
>>   
>> -	if (!phydev->is_on_sfp_module)
>> -		phy_led_triggers_unregister(phydev);
>> -
> It would be nice to mention this reorder in the commit message. The
> commit message is about "Why?". Explain why the order has been
> changed.
> 	
>      Andrew

Sure, I'll explain it in more detail in the next revision.

Thanks,
Xuanqiang