All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/de: prefer intel_reg_offset() over i915_mmio_reg_offset()
Date: Thu, 19 Nov 2026 11:32:44 +0200	[thread overview]
Message-ID: <e1f97e61963270c7da524f5050afff8847b3f911@intel.com> (raw)
In-Reply-To: <av3QdAbcdznpwqyV@intel.com>

On Wed, 18 Nov 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Nov 18, 2026 at 11:45:08AM +0200, Jani Nikula wrote:
>> intel_reg_offset() should be preferred over i915_mmio_reg_offset() in
>> display code. Convert the couple of instances that have crept in.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Sorry about that chief. I have a vague recollection of changing
> these, but evidently I either imagined it or lost it accidentally
> in some rebase.

Blame it on poor review. ;)

> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed to din.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_de.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_de.c b/drivers/gpu/drm/i915/display/intel_de.c
>> index 9ca5b27eb768..08a0027e7930 100644
>> --- a/drivers/gpu/drm/i915/display/intel_de.c
>> +++ b/drivers/gpu/drm/i915/display/intel_de.c
>> @@ -219,7 +219,7 @@ static void check_unclaimed_mmio_pre(struct intel_display *display,
>>  		drm_dbg_kms(display->drm,
>>  			    "Unclaimed access detected before %s register 0x%x\n",
>>  			    write ? "write to" : "read from",
>> -			    i915_mmio_reg_offset(reg));
>> +			    intel_reg_offset(reg));
>>  }
>>  
>>  static void check_unclaimed_mmio_post(struct intel_display *display,
>> @@ -234,7 +234,7 @@ static void check_unclaimed_mmio_post(struct intel_display *display,
>>  		     display->mmio.funcs->check_for_unclaimed_mmio(display),
>>  		     "Unclaimed %s register 0x%x\n",
>>  		     write ? "write to" : "read from",
>> -		     i915_mmio_reg_offset(reg)))
>> +		     intel_reg_offset(reg)))
>>  		/* Only report the first N failures */
>>  		display->params.mmio_debug--;
>>  }
>> -- 
>> 2.47.3

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-11-19  9:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:45 [PATCH] drm/i915/de: prefer intel_reg_offset() over i915_mmio_reg_offset() Jani Nikula
2026-11-18 10:33 ` ✓ CI.KUnit: success for " Patchwork
2026-11-18 11:10 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-18 11:47 ` ✓ i915.CI.BAT: " Patchwork
2026-11-18 14:08 ` ✓ i915.CI.Full: " Patchwork
2026-11-18 16:21 ` [PATCH] " Ville Syrjälä
2026-11-19  9:32   ` Jani Nikula [this message]
2026-11-19  0:27 ` ✓ Xe.CI.FULL: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1f97e61963270c7da524f5050afff8847b3f911@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.