All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Mario Limonciello <mario.limonciello@outlook.com>
Cc: linux-usb <linux-usb@vger.kernel.org>
Subject: Disabling intel-wmi-thunderbolt on devices without Thunderbolt / detecting if a device has Thunderbolt
Date: Mon, 25 Oct 2021 15:48:31 +0200	[thread overview]
Message-ID: <e21981cf-fef0-b73d-8fe4-4e1fab0d3864@redhat.com> (raw)

Hi All,

While digging through Microsoft Surface Go ACPI tables to fix an unrelated
issue, I noticed that there is an intel-wmi-thunderbolt WMI device in the
ACPI tables and the intel-wmi-thunderbolt driver happily binds to this.
This is likely the result of copy paste programming of the ACPI tables.

This causes a /sys/bus/wmi/devices/.../force_power attribute to be created
and echoing to that executes ACPI code which ends up poking at things it
should not be poking at on the Surface Go.

The problem of having these "nonsense" WMI devices with the
intel-wmi-thunderbolt GUID is likely more wide-spread and ideally the
intel-wmi-thunderbolt would ignore these.

This makes me wonder if there is a way to see if there are any thunderbolt
controllers on the system at all ? (with as goal to make intel-wmi-thunderbolt
not bind if there are none)

Regards,

Hans



             reply	other threads:[~2021-10-25 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 13:48 Hans de Goede [this message]
2021-10-25 14:46 ` Disabling intel-wmi-thunderbolt on devices without Thunderbolt / detecting if a device has Thunderbolt Oliver Neukum
     [not found] ` <PH0PR15MB4992B80415BE9BD4836CF336E1839@PH0PR15MB4992.namprd15.prod.outlook.com>
2021-10-25 14:54   ` Hans de Goede
2021-10-25 15:12     ` Mika Westerberg
2021-10-26  8:17       ` Hans de Goede
2021-10-26  8:53         ` Mika Westerberg
2021-10-26 10:34           ` Hans de Goede
2021-10-26 12:22             ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e21981cf-fef0-b73d-8fe4-4e1fab0d3864@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@outlook.com \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.