From: Andreas Heiduk <asheiduk@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file
Date: Thu, 5 Apr 2018 20:23:43 +0200 [thread overview]
Message-ID: <e2234113-52cf-1443-5abb-70a595037f30@gmail.com> (raw)
In-Reply-To: <20180405075113.3y6a5nadijswt7pm@untitled>
Am 05.04.2018 um 09:51 schrieb Eric Wong:
> Thanks for the update. The patch itself looks good, but I
> noticed one --show-item isn't supported on SVN 1.8.10 for me.
--show-item is indeed a 1.9.0 thing:
https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item
> I've tested the following on both SVN 1.8.10 and 1.9.5:
>
> --- a/t/t9138-git-svn-authors-prog.sh
> +++ b/t/t9138-git-svn-authors-prog.sh
> @@ -83,7 +83,8 @@ test_expect_success 'authors-prog imported user without email' '
> test_expect_success 'imported without authors-prog and authors-file' '
> svn mkdir -m hh --username hh "$svnrepo"/hh &&
> (
> - uuid=$(svn info --show-item=repos-uuid "$svnrepo") &&
> + uuid=$(svn info "$svnrepo" |
> + sed -n "s/^Repository UUID: //p") &&
> cd x &&
> git svn fetch &&
> git rev-list -1 --pretty=raw refs/remotes/git-svn | \
>
> Can you confirm it's OK for you? Thanks.
Looks good, works for me.
Do you squash this patch with with my commit or do you need a reroll?
next prev parent reply other threads:[~2018-04-05 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180304112237.19254-1-asheiduk@gmail.co>
2018-03-11 13:58 ` [PATCH v2 0/2] git-svn: --author-prog improvements Andreas Heiduk
2018-03-18 21:19 ` Andreas Heiduk
2018-03-18 21:31 ` Eric Sunshine
2018-03-11 13:58 ` [PATCH v2 1/2] git-svn: search --authors-prog in PATH too Andreas Heiduk
2018-03-11 13:58 ` [PATCH v2 2/2] git-svn: allow empty email-address in authors-prog and authors-file Andreas Heiduk
2018-03-18 23:04 ` Eric Wong
2018-03-19 22:48 ` Andreas Heiduk
2018-03-20 22:07 ` Eric Wong
2018-03-24 10:20 ` [PATCH v3] git-svn: allow empty email-address using " Andreas Heiduk
2018-04-05 7:51 ` Eric Wong
2018-04-05 18:23 ` Andreas Heiduk [this message]
2018-04-05 19:44 ` Eric Wong
2018-04-11 23:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2234113-52cf-1443-5abb-70a595037f30@gmail.com \
--to=asheiduk@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.