From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5EAC10F06 for ; Sat, 6 Apr 2019 20:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 445A6213F2 for ; Sat, 6 Apr 2019 20:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AlqSBMqM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbfDFUVw (ORCPT ); Sat, 6 Apr 2019 16:21:52 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:42492 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbfDFUVv (ORCPT ); Sat, 6 Apr 2019 16:21:51 -0400 Received: by mail-yb1-f193.google.com with SMTP id l124so2220229ybf.9 for ; Sat, 06 Apr 2019 13:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IDbjwyeUTS9BIQmPjtU46OsA1K8LaPXGMsI0WZfIsQw=; b=AlqSBMqMfaQi8vVThkMhthfaeDulDdTwl7AGAH7hG3eITNhjK1SR8kmDSHwntCUdXH sGLWxrcYeJjozQPsPIUZFtFjy6PjzOoNYoXNTDmHTS8C+WKoeUHtZVa2PKYkaRDiA7qk JBXTSHrr4GBR+Ldoqk1BsXa1wvh7egQhL+znQ33ynG693ysKDIdYauKOPJ99GGfJHd1U vjvVG0Bjck+a5Ze/sdcvbawvcZ8oWRIA2WGnHmCT07DbC2q+upBoIQ9C/zQR1e/OC4gV M2yDqucjsbp3833MVjnpVmngxdUl49T/0zNgikSd5lHIwIbiiwm381CWqWLy5sGjBJSa i10Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IDbjwyeUTS9BIQmPjtU46OsA1K8LaPXGMsI0WZfIsQw=; b=JW0jIBhOSxra+G6Gx2QM93chmLyQlRuKq1dOvl2N4q+B8gvFBPF7q8jIIHnPOPms3Y pL4Nf0DNpBrkPTKs6i5vtAN5KQTITull8Fs84VslPSoNxMKnxZa5/gfJrYLopWGDwJ86 0sEZ1xY8LlWZ+zx+SlKItMIEBcap3Bd/OmGOGUpyYpC3yTwHqNTGtKUJ9mTdCWXPbOos 1eQ3Ohg27iHt+b1R/HPt7VWw8F5K+u4O8FlkHLXKyX8Zh02AiWyKn7W2jPQeceONcbRX ABbaOdXPxAHmgfSdKr5B0i702PPQOcChx5mr71/Cv0gtdaADpU1IO9jzEj3IzUgJwY6v 1ftQ== X-Gm-Message-State: APjAAAVN2MLhxMcAgV9D7gbN+AK02M4UTXjr0XeO3BgZK5EYPn4SSmW8 v1IdcNKAScSuFeoJSJIAz5PaX2mg X-Google-Smtp-Source: APXvYqyAHbiWYK/zVWiTASyg7j0fKM+VVFikDKB8Jkdeo7Bz86rRw9D/Lw3h7A1nhOgNObmbiG+suA== X-Received: by 2002:a25:25cd:: with SMTP id l196mr11658844ybl.91.1554582110817; Sat, 06 Apr 2019 13:21:50 -0700 (PDT) Received: from [10.230.25.168] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id z204sm10709555ywb.28.2019.04.06.13.21.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 13:21:50 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve link partner capability detection To: Heiner Kallweit , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: Date: Sat, 6 Apr 2019 13:21:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/2019 12:23 PM, Heiner Kallweit wrote: > genphy_read_status() so far checks phydev->supported, not the actual > PHY capabilities. This can make a difference if the supported speeds > have been limited by of_set_phy_supported() or phy_set_max_speed(). > > It seems that this issue only affects the link partner advertisements > as displayed by ethtool. Also this patch wouldn't apply to older > kernels because linkmode bitmaps have been introduced recently. > Therefore net-next. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli -- Florian