Re: [PATCH iproute2] iplink: fix fd leak when playing with netns

[Alexandre Ferrieux <alexandre.ferrieux@gmail.com>]

On 17/09/2024 17:17, Nicolas Dichtel wrote:
> Le 17/09/2024 à 17:11, Stephen Hemminger a écrit :
>> On Tue, 17 Sep 2024 08:51:58 +0200
>> Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
>> 
>>> The command 'ip link set foo netns mynetns' opens a file descriptor to fill
>>> the netlink attribute IFLA_NET_NS_FD. This file descriptor is never closed.
>>> When batch mode is used, the number of file descriptor may grow greatly and
>>> reach the maximum file descriptor number that can be opened.
>>>
>>> This fd can be closed only after the netlink answer. Let's pass a new
>>> argument to iplink_parse() to remember this fd and close it.
>>>
>>> Fixes: 0dc34c7713bb ("iproute2: Add processless network namespace support")
>>> Reported-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>
>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>> Tested-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>
>>> ---
>> 
>> Maybe netns_fd should be a global variable rather than having to pass
>> to change all the unrelated function calls.
> I hesitated with this option. I don't have any strong opinion on this.
> 
> Note that two variables are needed, because the link_util->parse_opt may call
> again iplink_parse().
> 
> Another note that I forgot to mention: I didn't fix devlink which has the same
> problem. I was waiting for the conclusion of this fix first.

Another option would be to append "cleanup tasks" (a function pointer and a
single arg) to a global linked list; and call the chain at the end of the
execution of each single batch command. This allows for as many fds as are
needed, and other cleanups as well.

My $.02 ;)