All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [RFC PATCH] kbuild: add variables for compression tools
Date: Fri, 15 May 2020 12:40:04 +0300	[thread overview]
Message-ID: <e26a1565-e770-0e5e-c730-60cc6fa16a4f@linux.com> (raw)
In-Reply-To: <CAK7LNASRv9E-pfYCRmD-RstKhW+WgfHKrn+7bP_dAAkyKaoPGg@mail.gmail.com>

It seems that I missed a couple of tar commands in the patch:
scripts/Makefile.package
scripts/package/buildtar

On 5/15/20 5:20 AM, Masahiro Yamada wrote:
> On Thu, May 14, 2020 at 10:14 PM Denis Efremov <efremov@linux.com> wrote:
>>
> 
> commit 5054e88a7934d5ff5ec14231c8b8676161bb45fa
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Date:   Mon Mar 16 14:25:17 2015 -0700
> 
>     gzip: make the GZIP env var obsolescent

Other implementations can depend on this.
pigz still parses GZIP env var:
https://github.com/madler/pigz/blob/master/pigz.c#L4346

> 
> Some possible options I came up with:
> 
> 
> [1] Use KGZIP for now, but BZIP2, XZ, etc. for the others.
> 
>     (Then, rename KGZIP to GZIP when the time comes)
> 
> 
> [2] Do not take this patch
> 
>     The whole build process is parallelized
>     by 'make -j $(nproc)'.
> 
>     If you are still eager to use pigz instead gzip,
>     use a symbolic link or a wrapper shell script.
> 
>     $ ln -s /usr/bin/pigz  /$HOME/bin/gzip
>     $ PATH="$HOME/bin:$PATH"
> 

[3] GZIP at frontend, KGZIP or _GZIP internally? Something like:

$ cat Makefile
GZIP=gzip
override KGZIP=$(GZIP) # optional overrdide. Used to force GZIP value
                       # in case: make KGZIP=test

unexport GZIP
export KGZIP

default:
	@env | grep GZIP

$ make GZIP=test
KGZIP=test

Thanks,
Denis

  reply	other threads:[~2020-05-15  9:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 13:12 [RFC PATCH] kbuild: add variables for compression tools Denis Efremov
2020-05-15  2:20 ` Masahiro Yamada
2020-05-15  9:40   ` Denis Efremov [this message]
2020-05-21  7:20     ` Masahiro Yamada
2020-05-21 12:13 ` [RFC PATCH v2] " Denis Efremov
2020-05-22  8:43   ` Denis Efremov
2020-05-30 13:44 ` [RFC PATCH v3] " Denis Efremov
2020-06-01 12:45   ` Masahiro Yamada
2020-06-03  9:20 ` [RFC PATCH v4] " Denis Efremov
2020-06-04  0:12   ` Masahiro Yamada
2020-06-05  7:39 ` [PATCH v5] " Denis Efremov
2020-06-06 14:43   ` Masahiro Yamada
2020-06-08  1:30   ` Guenter Roeck
2020-06-08  4:59     ` Masahiro Yamada
2020-06-08  9:59       ` [PATCH] kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables Denis Efremov
2020-06-08 15:36         ` Adam Borowski
2020-06-08 16:23           ` Denis Efremov
2020-06-09  1:03         ` Masahiro Yamada
2020-06-08 10:28       ` [PATCH v5] kbuild: add variables for compression tools Denis Efremov
2020-06-08 13:52         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e26a1565-e770-0e5e-c730-60cc6fa16a4f@linux.com \
    --to=efremov@linux.com \
    --cc=dvyukov@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.