All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Das, Nirmoy" <nirmoy.das@amd.com>
To: dri-devel@lists.freedesktop.org
Cc: thomas_os@shipmail.org, linux-graphics-maintainer@vmware.com,
	Christian.Koenig@amd.com
Subject: Re: [PATCH 1/1] drm/vmwgfx: free bo resource before assigning new one
Date: Tue, 8 Jun 2021 20:05:17 +0200	[thread overview]
Message-ID: <e27b8e2d-cdc5-5dfd-0632-516cef0039f3@amd.com> (raw)
In-Reply-To: <20210608180135.10953-1-nirmoy.das@amd.com>

Please ignore this,  I wanted to send 
https://patchwork.kernel.org/project/dri-devel/patch/20210503190013.91732-1-nirmoy.das@amd.com/

after rebase.

On 6/8/2021 8:01 PM, Nirmoy Das wrote:
> ttm_bo_assign_mem() expects bo->resource to be free.
> Fixes: bfa3357ef9abc ("drm/ttm: allocate resource object instead of embedding it v2")
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> index bfcf31bf7e37..7281912436bb 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> @@ -733,6 +733,7 @@ static int vmw_move(struct ttm_buffer_object *bo,
>   
>   	if (old_man->use_tt && new_man->use_tt) {
>   		if (bo->resource->mem_type == TTM_PL_SYSTEM) {
> +			ttm_resource_free(bo, &bo->resource);
>   			ttm_bo_assign_mem(bo, new_mem);
>   			return 0;
>   		}

  reply	other threads:[~2021-06-08 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 15:09 [PATCH 1/1] drm/vmwgfx: free bo resource before assigning new one Nirmoy Das
2021-06-08 17:28 ` Christian König
2021-06-08 17:54   ` Das, Nirmoy
2021-06-08 18:01   ` Nirmoy Das
2021-06-08 18:05     ` Das, Nirmoy [this message]
2021-06-08 18:13   ` [PATCH 1/1] drm/vmwgfx: use ttm_bo_move_null() when there is nothing to move Nirmoy Das
2021-06-09  6:38     ` Christian König
2021-06-09  9:05       ` Das, Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e27b8e2d-cdc5-5dfd-0632-516cef0039f3@amd.com \
    --to=nirmoy.das@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=thomas_os@shipmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.