From: Jirong Feng <jirong.feng@easystack.cn>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, peng.xiao@easystack.cn
Subject: Re: Should NVME_SC_INVALID_NS be translated to BLK_STS_IOERR instead of BLK_STS_NOTSUPP so that multipath(both native and dm) can failover on the failure?
Date: Tue, 2 Jan 2024 18:33:45 +0800 [thread overview]
Message-ID: <e27ef3fd-d43c-4dc2-8969-4a0f86d9c64c@easystack.cn> (raw)
In-Reply-To: <ae40ced9-9f30-4e93-813c-5b94d0667d66@grimberg.me>
in function nvmet_subsys_nsid_exists() added in the patch, remove the
'\n' from line `if (sprintf(name, "%u\n", nsid) <= 0)`, the patch works
exactly as what I expect, fio keeps running and multipath does failover.
> Can you paste the log output (host and controller)?
>
host:
[Tue Jan 2 10:22:11 2024] print_req_error: 8 callbacks suppressed
[Tue Jan 2 10:22:11 2024] print_req_error: I/O error, dev nvme1n1,
sector 186257448 flags ca01
[Tue Jan 2 10:22:11 2024] device-mapper: multipath: Failing path 259:1.
[Tue Jan 2 10:22:11 2024] nvme nvme1: rescanning namespaces.
[Tue Jan 2 10:22:11 2024] device-mapper: multipath round-robin:
repeat_count > 1 is deprecated, using 1 instead
target:
[Tue Jan 2 10:21:57 2024] nvmet: ctrl 1 update keep-alive timer for 15 secs
[Tue Jan 2 10:22:12 2024] nvmet: jirong add: returning
NVME_ANA_PERSISTENT_LOSS
[Tue Jan 2 10:22:12 2024] nvmet_tcp: failed cmd 00000000de551a59 id 37
opcode 1, data_len: 4096
[Tue Jan 2 10:22:12 2024] nvmet: ctrl 1 reschedule traffic based
keep-alive timer
[Tue Jan 2 10:22:17 2024] nvmet: ctrl 1 update keep-alive timer for 15 secs
next prev parent reply other threads:[~2024-01-02 10:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 7:58 Should NVME_SC_INVALID_NS be translated to BLK_STS_IOERR instead of BLK_STS_NOTSUPP so that multipath(both native and dm) can failover on the failure? Jirong Feng
2023-12-04 8:47 ` Sagi Grimberg
2023-12-05 3:54 ` Jirong Feng
2023-12-05 4:37 ` Keith Busch
2023-12-05 4:40 ` Christoph Hellwig
2023-12-05 5:18 ` Keith Busch
2023-12-05 7:06 ` Jirong Feng
2023-12-05 8:50 ` Sagi Grimberg
2023-12-25 11:25 ` Jirong Feng
2023-12-25 11:40 ` Sagi Grimberg
2023-12-25 12:14 ` Jirong Feng
2023-12-26 13:27 ` Jirong Feng
2024-01-01 9:51 ` Sagi Grimberg
2024-01-02 10:33 ` Jirong Feng [this message]
2024-01-02 12:46 ` Sagi Grimberg
2024-01-03 10:24 ` Jirong Feng
2024-01-04 11:56 ` Sagi Grimberg
2024-01-30 9:36 ` Jirong Feng
2024-01-30 11:29 ` Sagi Grimberg
2024-01-31 6:25 ` Christoph Hellwig
2024-03-20 3:17 ` Jirong Feng
2024-03-20 8:51 ` Sagi Grimberg
2024-03-21 3:06 ` Jirong Feng
2024-04-07 22:28 ` Sagi Grimberg
2024-04-12 7:52 ` Jirong Feng
2024-04-12 8:57 ` Sagi Grimberg
2024-04-22 9:47 ` Sagi Grimberg
2024-04-23 3:15 ` Jirong Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e27ef3fd-d43c-4dc2-8969-4a0f86d9c64c@easystack.cn \
--to=jirong.feng@easystack.cn \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=peng.xiao@easystack.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.