All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Nico Pache <npache@redhat.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-doc@vger.kernel.org, kirill.shutemov@linux.intel.com
Cc: corbet@lwn.net, akpm@linux-foundation.org, surenb@google.com,
	pasha.tatashin@soleen.com, catalin.marinas@arm.com,
	jeffxu@chromium.org, andrii@kernel.org, xu.xin16@zte.com.cn
Subject: Re: [PATCH] Documentation: Add "Unaccepted" meminfo entry
Date: Tue, 18 Mar 2025 09:42:31 +0100	[thread overview]
Message-ID: <e2807c0f-c6db-4946-a731-009d34c2c72e@redhat.com> (raw)
In-Reply-To: <20250317230403.79632-1-npache@redhat.com>

On 18.03.25 00:04, Nico Pache wrote:
> Commit dcdfdd40fa82 ("mm: Add support for unaccepted memory") added a
> entry to meminfo but did not document it in the proc.rst file.
> 
> This counter tracks the amount of "Unaccepted" guest memory for some
> Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP.
> 
> Add the missing entry in the documentation.
> 
> Signed-off-by: Nico Pache <npache@redhat.com>
> ---
>   Documentation/filesystems/proc.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 09f0aed5a08b..8fcf19c31b18 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1060,6 +1060,7 @@ Example output. You may not have all of these fields.
>       FilePmdMapped:         0 kB
>       CmaTotal:              0 kB
>       CmaFree:               0 kB
> +    Unaccepted:            0 kB
>       HugePages_Total:       0
>       HugePages_Free:        0
>       HugePages_Rsvd:        0
> @@ -1228,6 +1229,8 @@ CmaTotal
>                 Memory reserved for the Contiguous Memory Allocator (CMA)
>   CmaFree
>                 Free remaining memory in the CMA reserves
> +Unaccepted
> +              Memory that has not been accepted by the guest

I was wondering if we could be clearer like

"Memory that has not been accepted. Especially in some confidential VM 
implementations, memory must be accepted manually by the guest OS before 
it can be used the first time."

In any case

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb


  parent reply	other threads:[~2025-03-18  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 23:04 [PATCH] Documentation: Add "Unaccepted" meminfo entry Nico Pache
2025-03-18  7:47 ` Kirill A. Shutemov
2025-03-18  8:42 ` David Hildenbrand [this message]
2025-03-18 18:01   ` Nico Pache

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2807c0f-c6db-4946-a731-009d34c2c72e@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=jeffxu@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npache@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=surenb@google.com \
    --cc=xu.xin16@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.