From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tarang Raval <tarang.raval@siliconsignals.io>
Cc: Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Gregor Herburger <gregor.herburger@ew.tq-group.com>,
Joao Paulo Goncalves <joao.goncalves@toradex.com>,
Hiago De Franco <hiago.franco@toradex.com>,
Mathieu Othacehe <m.othacehe@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Josua Mayer <josua@solid-run.com>, Yannic Moog <y.moog@phytec.de>,
Li Yang <leoyang.li@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
Date: Mon, 2 Sep 2024 09:47:23 +0200 [thread overview]
Message-ID: <e294c334-8d02-4f56-b4ba-e63d94a70a12@kernel.org> (raw)
In-Reply-To: <PN3P287MB182944940AB38804B65D58888B922@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
On 02/09/2024 09:23, Tarang Raval wrote:
> Hi,
>
>>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
>>
>> ??? No, there is no difference. You did not test your patches either.
>
> I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors.
Ah, you are right, I missed what actually changed.
>
>> When I wrote "This is not correct", it means you should drop it.
>> Incorrect compatibles should not be added.
>
> Sure I will Drop it.
I guess I wasn't precise. Please drop that one diff hunk.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-02 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 6:56 [PATCH v2 0/2] Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM Tarang Raval
2024-09-02 6:56 ` [PATCH v2 1/2] arm64: dts: imx8mp-var-som-symphony: Add " Tarang Raval
2024-09-02 6:56 ` [PATCH v2 2/2] dt-bindings: arm: fsl: " Tarang Raval
2024-09-02 6:59 ` Krzysztof Kozlowski
2024-09-02 7:07 ` Tarang Raval
2024-09-02 7:14 ` Krzysztof Kozlowski
2024-09-02 7:23 ` Tarang Raval
2024-09-02 7:47 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e294c334-8d02-4f56-b4ba-e63d94a70a12@kernel.org \
--to=krzk@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregor.herburger@ew.tq-group.com \
--cc=hiago.franco@toradex.com \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=joao.goncalves@toradex.com \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.othacehe@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=tarang.raval@siliconsignals.io \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.