All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: "Christoph Lameter (Ampere)" <cl@gentwo.org>,
	Yan Zhen <yanzhen@vivo.com>
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, roman.gushchin@linux.dev,
	42.hyeyoo@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] mm:slab:use kmem_cache_free() to free
Date: Tue, 27 Aug 2024 16:49:58 +0200	[thread overview]
Message-ID: <e29f5bb2-6daf-4542-9a56-b2e2d9e2d202@suse.cz> (raw)
In-Reply-To: <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org>

On 8/22/24 18:59, Christoph Lameter (Ampere) wrote:
> On Thu, 22 Aug 2024, Yan Zhen wrote:
> 
>> The kmem_cache_alloc() is typically used to free memory allocated through
>> the kernel memory cache (slab allocator).
> 
> Well yes but since we removed SLOB we can use kfree() on any slab object.
> 
>> Using kmem_cache_free() for deallocation may be more reasonable.
> 
> 
> It is more symmetric and looks better.

Right, added to slab/for-next, thanks.

> Reviewed-by: Christoph Lameter <cl@linux.com>


  reply	other threads:[~2024-08-27 14:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  2:27 [PATCH v1] mm:slab:use kmem_cache_free() to free Yan Zhen
2024-08-22 16:59 ` Christoph Lameter (Ampere)
2024-08-27 14:49   ` Vlastimil Babka [this message]
2024-08-27 14:57     ` Vlastimil Babka
2024-08-27 15:54 ` [PATCH] mm: slab: use " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e29f5bb2-6daf-4542-9a56-b2e2d9e2d202@suse.cz \
    --to=vbabka@suse.cz \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=opensource.kernel@vivo.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=yanzhen@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.