From: Eduard Zingerman <eddyz87@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Emil Tsalapatis <emil@etsalapatis.com>,
kkd@meta.com, kernel-team@meta.com
Subject: Re: [PATCH bpf-next v8 2/6] bpf: Attribute async callback instructions to verification roots
Date: Wed, 12 Aug 2026 17:39:18 -0700 [thread overview]
Message-ID: <e2b1029ee3473e43603412c185302757c918b17f.camel@gmail.com> (raw)
In-Reply-To: <20260812221925.3358041-3-memxor@gmail.com>
On Thu, 2026-08-13 at 00:19 +0200, Kumar Kartikeya Dwivedi wrote:
> Asynchronous callbacks are explored as fresh frame-zero verifier states,
> so normal callee-to-caller accounting cannot propagate their instruction
> budget to the main or global subprogram whose verification scheduled them.
>
> The callback exploration still happens within the same do_check_common()
> invocation as that independent verification root. Record
> env->insn_processed at do_check_common() entry and override the root's
> inclusive count with the delta before returning. This includes all directly
> and transitively scheduled asynchronous callbacks in the root's total
> without maintaining a separate accounting call stack.
>
> Static subprogram and callback totals remain local to their synchronous call
> paths. Their self counts continue to account for each processed instruction
> exactly once.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
...
next prev parent reply other threads:[~2026-08-13 0:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 22:19 [PATCH bpf-next v8 0/6] Improve stack depth verification stats output Kumar Kartikeya Dwivedi
2026-08-12 22:19 ` [PATCH bpf-next v8 1/6] bpf: Track verifier instruction stats for each subprogram Kumar Kartikeya Dwivedi
2026-08-12 22:19 ` [PATCH bpf-next v8 2/6] bpf: Attribute async callback instructions to verification roots Kumar Kartikeya Dwivedi
2026-08-13 0:39 ` Eduard Zingerman [this message]
2026-08-12 22:19 ` [PATCH bpf-next v8 3/6] bpf: Show more useful info in stack depth stats Kumar Kartikeya Dwivedi
2026-08-12 22:29 ` sashiko-bot
2026-08-12 23:14 ` bot+bpf-ci
2026-08-12 22:19 ` [PATCH bpf-next v8 4/6] selftests/bpf: Adjust veristat stack depth parsing Kumar Kartikeya Dwivedi
2026-08-12 23:14 ` bot+bpf-ci
2026-08-12 22:19 ` [PATCH bpf-next v8 5/6] selftests/bpf: Test stack depth stats without BTF subprog names Kumar Kartikeya Dwivedi
2026-08-12 23:14 ` bot+bpf-ci
2026-08-12 22:19 ` [PATCH bpf-next v8 6/6] selftests/bpf: Test subprogram instruction statistics Kumar Kartikeya Dwivedi
2026-08-13 0:50 ` [PATCH bpf-next v8 0/6] Improve stack depth verification stats output patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b1029ee3473e43603412c185302757c918b17f.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=kernel-team@meta.com \
--cc=kkd@meta.com \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.