Re: [PATCH v4 04/17] wifi: cc33xx: Add sdio.c, io.c, io.h

["Nemanov, Michael" <michael.nemanov@ti.com>]

On 10/29/2024 7:34 PM, Krzysztof Kozlowski wrote:

...

>> +
>> +void cc33xx_disable_interrupts_nosync(struct cc33xx *cc)
>> +{
>> +	cc->if_ops->disable_irq(cc->dev);
>> +}
>> +
>> +void cc33xx_irq(void *cookie);
> 
> Why do you need forward declaration of non-static function? If you need
> it, it means you had W=1 warning which you fixed incorrect way.
> 
> Regardless, be sure this code has 0 warnings on clang with W=1.
> 

Indeed a refactoring leftover (already moved to a header file) will fix.

...

>> +
>> +static struct sdio_driver cc33xx_sdio_driver = {
>> +	.name		= "cc33xx_sdio",
>> +	.id_table	= cc33xx_devices,
>> +	.probe		= sdio_cc33xx_probe,
>> +	.remove		= sdio_cc33xx_remove,
>> +#ifdef CONFIG_PM
>> +	.drv = {
>> +		.pm = &cc33xx_sdio_pm_ops,
>> +	},
>> +#endif /* CONFIG_PM */
>> +};
>> +
>> +MODULE_DEVICE_TABLE(sdio, cc33xx_devices);
> 
> This is always next to the table.
> 

Will fix.

Regards,
Michael.