From: Florian Eckert <fe@dev.tdt.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Eckert.Florian@googlemail.com, "Enrico Weigelt,
metux IT consult" <info@metux.net>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Update pcengines-apuv2 platform device
Date: Thu, 04 Jul 2019 16:00:35 +0200 [thread overview]
Message-ID: <e2c50449b498c796de8258fac0b0aba6@dev.tdt.de> (raw)
In-Reply-To: <CAHp75Vcocs=9AwX32ouOWFc+wAduCFv2DT_p4JYPUVV0BumjqA@mail.gmail.com>
Hello Andy,
thanks for feedback
>> This patchset adds the following changes to this pcengines-apuv2
>> platform device.
>>
>
> Before doing anything to this driver, what is the plan for previously
> upstreamed:
>
> drivers/leds/leds-apu.c
I think we can remove the related APU2/APU3 code stuff from this driver.
The recently added pcengines-apuv2 driver does *not* support the APU1.
So I think we need the related APU1 stuff if we still want to support
this board.
> arch/x86/platform/geode/alix.c
I think this is not related because this is a different platform driver.
Maybe we should move them to drivers/platform/x86?
Regards
Florian
next prev parent reply other threads:[~2019-07-04 14:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 9:02 [PATCH 0/3] Update pcengines-apuv2 platform device Florian Eckert
2019-07-04 9:02 ` [PATCH 1/3] platform/x86/pcengines-apuv2: add mpcie reset gpio export Florian Eckert
2019-07-08 19:44 ` Enrico Weigelt, metux IT consult
2019-07-10 12:30 ` Florian Eckert
2019-07-15 12:15 ` Enrico Weigelt, metux IT consult
2019-07-15 14:38 ` Florian Eckert
2019-07-16 18:23 ` Enrico Weigelt, metux IT consult
2019-07-22 11:25 ` Enrico Weigelt, metux IT consult
2019-07-04 9:02 ` [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions Florian Eckert
2019-07-08 19:42 ` Enrico Weigelt, metux IT consult
2019-07-10 12:03 ` Florian Eckert
2019-07-10 13:07 ` Enrico Weigelt, metux IT consult
2019-07-04 9:02 ` [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition Florian Eckert
2019-07-08 19:27 ` Enrico Weigelt, metux IT consult
2019-07-22 11:27 ` Enrico Weigelt, metux IT consult
2019-07-23 7:06 ` Florian Eckert
2019-07-23 23:00 ` Enrico Weigelt, metux IT consult
2019-07-04 13:39 ` [PATCH 0/3] Update pcengines-apuv2 platform device Andy Shevchenko
2019-07-04 14:00 ` Florian Eckert [this message]
2019-07-04 14:26 ` Andy Shevchenko
2019-07-05 11:36 ` Florian Eckert
2019-07-08 19:39 ` Enrico Weigelt, metux IT consult
2019-07-08 19:45 ` Enrico Weigelt, metux IT consult
2019-07-10 12:54 ` Florian Eckert
2019-07-25 17:49 ` Andy Shevchenko
2019-07-25 19:12 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2c50449b498c796de8258fac0b0aba6@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.