All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goran Radenovic <goran.radni@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: boerge.struempfel@gmail.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Date: Fri, 20 Jun 2025 10:53:52 +0200	[thread overview]
Message-ID: <e2cd9f09-b984-4409-9b3b-7b6335dd23ea@gmail.com> (raw)
In-Reply-To: <578ea477-c68c-4427-8013-550bf4f9c05b@kernel.org>



Krzysztof Kozlowski wrote:
> On 12/06/2025 12:09, Goran Radenovic wrote:
>> Hi Krzysztof,
>>
>> Thanks for the feedback, and you're absolutely right — I made a mistake
>> here.
>>
>> That said, I’m still a bit confused by your earlier comment:
>>
>>       "That's just part of the standard/first enum."
>>
>> I’m introducing a new board from a new manufacturer, so I expected to
>> add a new enum block — similar to how it's done for other vendor entries
> 
> No, you are expected to add to existing enum.

Very well, I'll add the entry to the existing `description: i.MX8MP 
based Boards` block.

> 
>> in the same file. I ran dt_binding_check, and it passed without errors
>> for this structure.
> 
> Not possible. The syntax is clearly wrong, so there is no way it passed
> any tests. And Rob's report is a proof of that.
> 

You are right for v2. I was referring to v1. Sorry for the confusion.

>>
>> Could you clarify which “standard/first enum” you were referring to?
>> Should all i.MX8MP-based boards share a single enum block, regardless of
>> vendor?
> 
> Don't they? Look around in this file.
> 

I did, and I've learned something.

>>
>> Thanks again for your guidance.
> 
> Don't top post but reply inline.
> 

Ok, thank you for the correction.

> Best regards,
> Krzysztof


Best regards
Goran

  reply	other threads:[~2025-06-20  8:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 11:30 [PATCH v2 0/3] arm64: dts: Add support for Ultratronik i.MX8MP Ultra-MACH SBC Goran Rađenović
2025-06-11 11:30 ` [PATCH v2 1/3] MAINTAINERS: Add i.MX8MP Ultra-MACH SBC to ULTRATRONIK BOARD SUPPORT Goran Rađenović
2025-06-11 11:30 ` [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC Goran Rađenović
2025-06-12  0:07   ` Rob Herring (Arm)
2025-06-12  7:09   ` Krzysztof Kozlowski
2025-06-12 10:09     ` Goran Radenovic
2025-06-12 11:01       ` Krzysztof Kozlowski
2025-06-20  8:53         ` Goran Radenovic [this message]
2025-06-11 11:30 ` [PATCH v2 3/3] arm64: dts: imx8mp: Add initial support for Ultratronik imx8mp-ultra-mach-sbc board Goran Rađenović
2025-06-11 15:34   ` Frank Li
2025-06-20  9:58     ` Goran Radenovic
2025-06-11 13:11 ` [PATCH v2 0/3] arm64: dts: Add support for Ultratronik i.MX8MP Ultra-MACH SBC Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2cd9f09-b984-4409-9b3b-7b6335dd23ea@gmail.com \
    --to=goran.radni@gmail.com \
    --cc=boerge.struempfel@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.