From: Eric Auger <eauger@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Keith Busch <kbusch@meta.com>,
hch@lst.de, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, axboe@kernel.dk,
Jeff Moyer <jmoyer@redhat.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: Re: [PATCHv5 1/2] block: accumulate memory segment gaps per bio
Date: Mon, 17 Aug 2026 18:37:25 +0200 [thread overview]
Message-ID: <e2da7cc1-3ab8-408c-b561-345de5a33963@redhat.com> (raw)
In-Reply-To: <aoMxLBmKfFo_-i1u@kbusch-mbp>
Hi Keith,
On 8/17/26 6:05 PM, Keith Busch wrote:
> ---
> diff --git a/block/bio.c b/block/bio.c
> index 4074a0496b93f..c343788e1f96e 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -859,6 +859,7 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
> bio->bi_ioprio = bio_src->bi_ioprio;
> bio->bi_write_hint = bio_src->bi_write_hint;
> bio->bi_write_stream = bio_src->bi_write_stream;
> + bio->bi_bvec_gap_bit = bio_src->bi_bvec_gap_bit;
> bio->bi_iter = bio_src->bi_iter;
>
> if (bio->bi_bdev) {
> @@ -1969,6 +1970,7 @@ struct bio *bio_split(struct bio *bio, int sectors,
> bio_integrity_trim(split);
>
> bio_advance(bio, split->bi_iter.bi_size);
> + bio->bi_bvec_gap_bit = 0;
>
> if (bio_flagged(bio, BIO_TRACE_COMPLETION))
> bio_set_flag(split, BIO_TRACE_COMPLETION);
> --
Many thanks for your quick investigations. With that patch I do not see
the IO errors anymore so it seems it fixes my issues.
Thanks
Eric
next prev parent reply other threads:[~2026-08-17 16:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 15:04 [PATCHv5 0/2] block, nvme: removing virtual boundary mask reliance Keith Busch
2025-10-14 15:04 ` [PATCHv5 1/2] block: accumulate memory segment gaps per bio Keith Busch
2025-10-14 21:18 ` Martin K. Petersen
2025-10-15 4:08 ` Christoph Hellwig
2025-11-11 4:26 ` Matthew Wilcox
2025-11-11 4:50 ` Keith Busch
2025-11-11 7:14 ` Christoph Hellwig
2025-11-11 9:36 ` Yu Kuai
2025-11-11 9:39 ` Christoph Hellwig
2025-11-11 10:14 ` Yu Kuai
2025-11-11 13:25 ` Keith Busch
2025-11-11 13:40 ` Christoph Hellwig
2025-11-11 13:54 ` Keith Busch
2025-11-11 13:58 ` Christoph Hellwig
2025-11-11 14:03 ` Yu Kuai
2026-08-17 13:23 ` Eric Auger
2026-08-17 15:04 ` Keith Busch
2026-08-17 15:12 ` Eric Auger
2026-08-17 16:05 ` Keith Busch
2026-08-17 16:37 ` Eric Auger [this message]
2025-10-14 15:04 ` [PATCHv5 2/2] nvme: remove virtual boundary for sgl capable devices Keith Busch
2025-10-14 21:19 ` Martin K. Petersen
2025-11-07 1:03 ` [PATCHv5 0/2] block, nvme: removing virtual boundary mask reliance Keith Busch
2025-11-07 1:12 ` Jens Axboe
2025-11-07 1:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2da7cc1-3ab8-408c-b561-345de5a33963@redhat.com \
--to=eauger@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=jsnitsel@redhat.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.