From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3984DC07E97 for ; Wed, 29 Nov 2023 09:07:39 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643765.1004233 (Exim 4.92) (envelope-from ) id 1r8GXX-00061S-1k; Wed, 29 Nov 2023 09:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643765.1004233; Wed, 29 Nov 2023 09:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8GXW-00061L-Uw; Wed, 29 Nov 2023 09:07:26 +0000 Received: by outflank-mailman (input) for mailman id 643765; Wed, 29 Nov 2023 09:07:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8GXV-0005zO-EF for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 09:07:25 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5dc9c59-8e96-11ee-98e3-6d05b1d4d9a1; Wed, 29 Nov 2023 10:07:24 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id E32644EE0737; Wed, 29 Nov 2023 10:07:23 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5dc9c59-8e96-11ee-98e3-6d05b1d4d9a1 MIME-Version: 1.0 Date: Wed, 29 Nov 2023 10:07:23 +0100 From: Nicola Vetrini To: Stefano Stabellini Cc: Jan Beulich , Andrew Cooper3 , Julien Grall , George Dunlap , Wei Liu , Xen Devel Subject: Re: MISRA: Compatible declarations for sort and bsearch In-Reply-To: References: <5ebb62b5485bb1a0c4e805af6580ab6d@bugseng.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2023-11-29 04:26, Stefano Stabellini wrote: > On Mon, 27 Nov 2023, Nicola Vetrini wrote: >> > > /* >> > > * TODO: make first_valid_mfn static when NUMA is supported on Arm, this >> > > * is required because the dummy helpers are using it. >> > > */ >> > > extern mfn_t first_valid_mfn; >> > > >> > > it should probably be deviated. >> > >> > NUMA work is still in progress for Arm, I think, so I'd rather wait with >> > deviating. >> > >> >> +Stefano >> >> I can leave it as is, if that's indeed going to become static at some >> point. > > I see the point in waiting given the TODO comment, but I wouldn't want > this issue to be the only thing standing between us and zero violation > of Rule 8.4 on ARM. So I think we should add SAF to the comment and > remove it when not necessary any longer. Ok, thanks. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)