All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	christian.koenig-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: GPU vs CPU page size fixes in amdgpu_vm_bo_split_mapping
Date: Fri, 22 Jun 2018 16:57:50 +0200	[thread overview]
Message-ID: <e2fc70ce-b347-dc17-5de5-fa729da49aba@gmail.com> (raw)
In-Reply-To: <a3a30887-bb0e-1d90-69ca-21fac8f35b62-otUistvHUpPR7s880joybQ@public.gmane.org>

Am 22.06.2018 um 16:12 schrieb Michel Dänzer:
> On 2018-06-22 12:34 PM, Christian König wrote:
>> Am 22.06.2018 um 11:10 schrieb Michel Dänzer:
>>> From: Michel Dänzer <michel.daenzer@amd.com>
>>>
>>> start / last / max_entries are numbers of GPU pages, pfn / count are
>>> numbers of CPU pages. Convert between them accordingly.
>>>
>>> Fixes badness on systems with > 4K page size.
>>>
>>> Cc: stable@vger.kernel.org
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106258
>>> Reported-by: Matt Corallo <freedesktop@bluematt.me>
>>> Tested-by: foxbat@ruin.net
>>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
>> Nice work!
> Thanks.
>
>
>> Just one comment: Can we somewhere add a define for
>> "(PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE)"?
>>
>> IIRC that term was used in the GART code as well and just adding it
>> somewhere could makes things cleaner if you ask me.
> Sure, but that can be a follow-up patch, right?
>
> Can I get your R-b for this one?

Certainly, patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

Thanks,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-06-22 14:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22  9:10 [PATCH] drm/amdgpu: GPU vs CPU page size fixes in amdgpu_vm_bo_split_mapping Michel Dänzer
     [not found] ` <20180622091035.4119-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-06-22 10:34   ` Christian König
     [not found]     ` <a2824504-f765-251c-5adb-dda69ecc9ca7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-06-22 14:12       ` Michel Dänzer
     [not found]         ` <a3a30887-bb0e-1d90-69ca-21fac8f35b62-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-06-22 14:57           ` Christian König [this message]
2018-06-22 14:18   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2fc70ce-b347-dc17-5de5-fa729da49aba@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.