From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B631CC77B73 for ; Sun, 23 Apr 2023 09:24:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7202885F74; Sun, 23 Apr 2023 11:24:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mY7bFFxr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42D7C85F7B; Sun, 23 Apr 2023 11:24:43 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A5C685DA6 for ; Sun, 23 Apr 2023 11:24:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-94f1d0d2e03so453392566b.0 for ; Sun, 23 Apr 2023 02:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682241880; x=1684833880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b+DBP/imqFSsWelQkSRTUiEjzuj1F7dujD/9VhYb7MA=; b=mY7bFFxrX0T777F6WjWlm66OzUltMGX/n+HIRf4OQmR1sRg1IjyXJjpCAXWDB3GTKk rGGnhWajYC2fqWaKyzhNrS7lyTMRt9k8gZPrvK2RIOcJz1wq8+nd/8xO9I0BAgBUwODh KTqvHfKHJsWoAgJM8wjwWewPzGSjbjRmzV9AM3+qEwmN0Vtv0AXlF4+slxJ2f6/SNLCg BPgF9g/2PdgMn3DPVdesy0a3lVGIcpS4ViCwp/obUeBzgINCrDNe4AVoKWUrWBTVmBXo V8ji+IwX6F/jzGduVKl+acoTc8LEX0Lo4h9CBHojIL8JyncIBmsmec7NGpKoCAdHYPUx 3g6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682241880; x=1684833880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b+DBP/imqFSsWelQkSRTUiEjzuj1F7dujD/9VhYb7MA=; b=bmAjnbMXavp1OBDfv4Vky4ea3Fm73St2jq2WL7GWNuoSuhW2pQqJsso1BsAB0vk/CH /jDo9t32PkRbFXRBhjVXUoKRe6tfkeUYsLRcFbr2dEWlHqDOgdR1BYUhLUnAqD9AquFQ D00xJhtgN0Vw+UOPuLIJ/tRGPbI0H7JEB85fpIYOz67fFB1hgRMbKb/B5XrDg/MVQB/J V+bT15xbWfC5w+s7anSZX5O41dAY79VGGigFj/HKasc4n4feUhYDIwbqDeiwuKP42V2W MOXY8XCoVRH/fy7KyYy74p59D0KkFRFQR3l8duFJ/jz0ye4hHvkAorSou7P6lrr2C8YD v4QQ== X-Gm-Message-State: AAQBX9eeqlwTaHaD9thEQDl6lQHlt5dXLSla1ZL+lJklZeXpuXzSzBuW vtOa3jbetzbeXq9qCai3Jyc= X-Google-Smtp-Source: AKy350a0RRfOm9f+sPRQqI1j9dOcn5ER8vBqzBtgV2oTRFqFZfXGE6gS29ejqOEOWheNlmGG8ARCDg== X-Received: by 2002:a17:906:fd47:b0:94e:75f8:668 with SMTP id wi7-20020a170906fd4700b0094e75f80668mr5909557ejb.56.1682241879788; Sun, 23 Apr 2023 02:24:39 -0700 (PDT) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id a8-20020a1709063e8800b0094e4684e5c0sm4175921ejj.25.2023.04.23.02.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 02:24:39 -0700 (PDT) Message-ID: Date: Sun, 23 Apr 2023 11:24:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1 Content-Language: en-US To: Kever Yang , dario.binacchi@amarulasolutions.com, michael@amarulasolutions.com, sjg@chromium.org, philipp.tomsich@vrull.eu Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com References: <482794b2-ee7b-6919-cc2c-014c1e2e908f@rock-chips.com> <5f0b9833-cd0e-bfb4-cbfb-0f4cdf7fcce8@gmail.com> <3ae6d256-63d4-1c6e-c14a-dbf87d7b9128@rock-chips.com> From: Johan Jonker In-Reply-To: <3ae6d256-63d4-1c6e-c14a-dbf87d7b9128@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/23/23 03:51, Kever Yang wrote: > Hi Johan, > > On 2023/4/21 23:34, Johan Jonker wrote: >> >> On 4/21/23 05:15, Kever Yang wrote: >>> Hi Johan, >>> >>>      I got below error report from CI test, I think it should be relate to this patch set. >>> >>> =================================== FAILURES =================================== >>> 1107 _________________ test_ut[ut_dm_dm_test_fdt_get_addr_ptr_flat] _________________ >>> 1108 test/py/tests/test_ut.py:346: in test_ut >>> 1109 assert output.endswith('Failures: 0') >>> 1110 E AssertionError: assert False >>> 1111 E + where False = ('Failures: 0') >>> 1112 E + where = 'Test: dm_test_fdt_get_addr_ptr_flat: test-fdt.c (flat tree)\r\r\ntest/dm/test-fdt.c:627, >> dm_test_fdt_get_addr_ptr_fla...xpected 0000000000008000, got 0000000010009000\r\r\nTest dm_test_fdt_get_addr_ptr_flat failed 1 times\r\r\nFailures: 1'.endswith >> >> It turns out that the suggestion by Simon to use map_sysmem() doesn't work with devfdt_get_addr_index_ptr() somehow. >> >> To reproduce with this serie: >> make sandbox_defconfig all >> ./u-boot -T -c "ut dm fdt*" >> >> Test: dm_test_fdt_get_addr_ptr_flat: test-fdt.c (flat tree) >> test/dm/test-fdt.c:627, dm_test_fdt_get_addr_ptr_flat(): (void *)0x8000 = ptr: Expected 0000000000008000, got 0000000010009000 >> Test fdt* failed 1 times >> >> === >> >> Could Simon have a look at the internal map_sysmem() stuff? >> >> Will send 1 patch to replace: >> [PATCH v8 14/24] core: fdtaddr: add devfdt_get_addr_size_index_ptr function >> >> for: >> >> [PATCH v9] core: fdtaddr: add devfdt_get_addr_size_index_ptr function >> >> Could Kever retest with the patch above replacement? > > The CI test pass with this replacement. I've sent a new separate patch that handles map_sysmem. [PATCH v9] core: fdtaddr: use map_sysmem() as cast for the return https://lore.kernel.org/u-boot/4990a11d-638f-661d-a7c0-e0c5bf7ff863@gmail.com/T/#u Apply after: [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1 with replacement: [PATCH v9] core: fdtaddr: add devfdt_get_addr_size_index_ptr function Please have a look. Johan > > > Thanks, > > - Kever >