From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiangyifei Date: Fri, 10 Dec 2021 10:03:40 +0000 Subject: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization In-Reply-To: References: <20211120074644.729-1-jiangyifei@huawei.com> <20211120074644.729-13-jiangyifei@huawei.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > -----Original Message----- > From: Richard Henderson [mailto:richard.henderson at linaro.org] > Sent: Sunday, November 21, 2021 6:35 AM > To: Jiangyifei ; qemu-devel at nongnu.org; > qemu-riscv at nongnu.org > Cc: bin.meng at windriver.com; limingwang (A) ; > kvm at vger.kernel.org; libvir-list at redhat.com; anup.patel at wdc.com; wanbo (G) > ; Alistair.Francis at wdc.com; > kvm-riscv at lists.infradead.org; Wanghaibin (D) > ; palmer at dabbelt.com; Fanliang (EulerOS) > ; Wubin (H) > Subject: Re: [PATCH v1 12/12] target/riscv: Support virtual time context > synchronization > > On 11/20/21 8:46 AM, Yifei Jiang wrote: > > const VMStateDescription vmstate_riscv_cpu = { > > .name = "cpu", > > .version_id = 3, > > .minimum_version_id = 3, > > + .post_load = cpu_post_load, > > .fields = (VMStateField[]) { > > VMSTATE_UINTTL_ARRAY(env.gpr, RISCVCPU, 32), > > VMSTATE_UINT64_ARRAY(env.fpr, RISCVCPU, 32), @@ -211,6 > > +221,10 @@ const VMStateDescription vmstate_riscv_cpu = { > > VMSTATE_UINT64(env.mtohost, RISCVCPU), > > VMSTATE_UINT64(env.timecmp, RISCVCPU), > > > > + VMSTATE_UINT64(env.kvm_timer_time, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_compare, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_state, RISCVCPU), > > + > > VMSTATE_END_OF_LIST() > > }, > > Can't alter VMStateDescription.fields without bumping version. > > If this is really kvm-only state, consider placing it into a subsection. But I > worry about kvm-only state because ideally we'd be able to migrate between > tcg and kvm (if only for debugging). > > > r~ Thanks, I will update the version in the next series and place it into a subsection. Yifei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mvckn-0004C2-N4 for mharc-qemu-riscv@gnu.org; Fri, 10 Dec 2021 05:03:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvckl-00045B-Fa; Fri, 10 Dec 2021 05:03:47 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]:2911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvcki-0005Bk-32; Fri, 10 Dec 2021 05:03:47 -0500 Received: from dggeme706-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J9RHM5kBbz1DLHg; Fri, 10 Dec 2021 18:00:47 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by dggeme706-chm.china.huawei.com (10.1.199.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Fri, 10 Dec 2021 18:03:40 +0800 Received: from kwepemm600017.china.huawei.com ([7.193.23.234]) by kwepemm600017.china.huawei.com ([7.193.23.234]) with mapi id 15.01.2308.020; Fri, 10 Dec 2021 18:03:40 +0800 From: Jiangyifei To: Richard Henderson , "qemu-devel@nongnu.org" , "qemu-riscv@nongnu.org" CC: "bin.meng@windriver.com" , "limingwang (A)" , "kvm@vger.kernel.org" , "libvir-list@redhat.com" , "anup.patel@wdc.com" , "wanbo (G)" , "Alistair.Francis@wdc.com" , "kvm-riscv@lists.infradead.org" , "Wanghaibin (D)" , "palmer@dabbelt.com" , "Fanliang (EulerOS)" , "Wubin (H)" Subject: RE: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization Thread-Topic: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization Thread-Index: AQHX3eLUE1sOoznHAU+RC9Ifd4t+hKwMe9AAgB8iu4A= Date: Fri, 10 Dec 2021 10:03:40 +0000 Message-ID: References: <20211120074644.729-1-jiangyifei@huawei.com> <20211120074644.729-13-jiangyifei@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.186.236] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.255; envelope-from=jiangyifei@huawei.com; helo=szxga08-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 10:03:47 -0000 DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFJpY2hhcmQgSGVuZGVyc29u IFttYWlsdG86cmljaGFyZC5oZW5kZXJzb25AbGluYXJvLm9yZ10NCj4gU2VudDogU3VuZGF5LCBO b3ZlbWJlciAyMSwgMjAyMSA2OjM1IEFNDQo+IFRvOiBKaWFuZ3lpZmVpIDxqaWFuZ3lpZmVpQGh1 YXdlaS5jb20+OyBxZW11LWRldmVsQG5vbmdudS5vcmc7DQo+IHFlbXUtcmlzY3ZAbm9uZ251Lm9y Zw0KPiBDYzogYmluLm1lbmdAd2luZHJpdmVyLmNvbTsgbGltaW5nd2FuZyAoQSkgPGxpbWluZ3dh bmdAaHVhd2VpLmNvbT47DQo+IGt2bUB2Z2VyLmtlcm5lbC5vcmc7IGxpYnZpci1saXN0QHJlZGhh dC5jb207IGFudXAucGF0ZWxAd2RjLmNvbTsgd2FuYm8gKEcpDQo+IDx3YW5ibzEzQGh1YXdlaS5j b20+OyBBbGlzdGFpci5GcmFuY2lzQHdkYy5jb207DQo+IGt2bS1yaXNjdkBsaXN0cy5pbmZyYWRl YWQub3JnOyBXYW5naGFpYmluIChEKQ0KPiA8d2FuZ2hhaWJpbi53YW5nQGh1YXdlaS5jb20+OyBw YWxtZXJAZGFiYmVsdC5jb207IEZhbmxpYW5nIChFdWxlck9TKQ0KPiA8ZmFubGlhbmdAaHVhd2Vp LmNvbT47IFd1YmluIChIKSA8d3Uud3ViaW5AaHVhd2VpLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQ QVRDSCB2MSAxMi8xMl0gdGFyZ2V0L3Jpc2N2OiBTdXBwb3J0IHZpcnR1YWwgdGltZSBjb250ZXh0 DQo+IHN5bmNocm9uaXphdGlvbg0KPiANCj4gT24gMTEvMjAvMjEgODo0NiBBTSwgWWlmZWkgSmlh bmcgd3JvdGU6DQo+ID4gICBjb25zdCBWTVN0YXRlRGVzY3JpcHRpb24gdm1zdGF0ZV9yaXNjdl9j cHUgPSB7DQo+ID4gICAgICAgLm5hbWUgPSAiY3B1IiwNCj4gPiAgICAgICAudmVyc2lvbl9pZCA9 IDMsDQo+ID4gICAgICAgLm1pbmltdW1fdmVyc2lvbl9pZCA9IDMsDQo+ID4gKyAgICAucG9zdF9s b2FkID0gY3B1X3Bvc3RfbG9hZCwNCj4gPiAgICAgICAuZmllbGRzID0gKFZNU3RhdGVGaWVsZFtd KSB7DQo+ID4gICAgICAgICAgIFZNU1RBVEVfVUlOVFRMX0FSUkFZKGVudi5ncHIsIFJJU0NWQ1BV LCAzMiksDQo+ID4gICAgICAgICAgIFZNU1RBVEVfVUlOVDY0X0FSUkFZKGVudi5mcHIsIFJJU0NW Q1BVLCAzMiksIEBAIC0yMTEsNg0KPiA+ICsyMjEsMTAgQEAgY29uc3QgVk1TdGF0ZURlc2NyaXB0 aW9uIHZtc3RhdGVfcmlzY3ZfY3B1ID0gew0KPiA+ICAgICAgICAgICBWTVNUQVRFX1VJTlQ2NChl bnYubXRvaG9zdCwgUklTQ1ZDUFUpLA0KPiA+ICAgICAgICAgICBWTVNUQVRFX1VJTlQ2NChlbnYu dGltZWNtcCwgUklTQ1ZDUFUpLA0KPiA+DQo+ID4gKyAgICAgICAgVk1TVEFURV9VSU5UNjQoZW52 Lmt2bV90aW1lcl90aW1lLCBSSVNDVkNQVSksDQo+ID4gKyAgICAgICAgVk1TVEFURV9VSU5UNjQo ZW52Lmt2bV90aW1lcl9jb21wYXJlLCBSSVNDVkNQVSksDQo+ID4gKyAgICAgICAgVk1TVEFURV9V SU5UNjQoZW52Lmt2bV90aW1lcl9zdGF0ZSwgUklTQ1ZDUFUpLA0KPiA+ICsNCj4gPiAgICAgICAg ICAgVk1TVEFURV9FTkRfT0ZfTElTVCgpDQo+ID4gICAgICAgfSwNCj4gDQo+IENhbid0IGFsdGVy IFZNU3RhdGVEZXNjcmlwdGlvbi5maWVsZHMgd2l0aG91dCBidW1waW5nIHZlcnNpb24uDQo+IA0K PiBJZiB0aGlzIGlzIHJlYWxseSBrdm0tb25seSBzdGF0ZSwgY29uc2lkZXIgcGxhY2luZyBpdCBp bnRvIGEgc3Vic2VjdGlvbi4gIEJ1dCBJDQo+IHdvcnJ5IGFib3V0IGt2bS1vbmx5IHN0YXRlIGJl Y2F1c2UgaWRlYWxseSB3ZSdkIGJlIGFibGUgdG8gbWlncmF0ZSBiZXR3ZWVuDQo+IHRjZyBhbmQg a3ZtIChpZiBvbmx5IGZvciBkZWJ1Z2dpbmcpLg0KPiANCj4gDQo+IHJ+DQoNClRoYW5rcywgSSB3 aWxsIHVwZGF0ZSB0aGUgdmVyc2lvbiBpbiB0aGUgbmV4dCBzZXJpZXMgYW5kIHBsYWNlIGl0IGlu dG8gYSBzdWJzZWN0aW9uLg0KDQpZaWZlaQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D6F6C433F5 for ; Fri, 10 Dec 2021 10:05:30 +0000 (UTC) Received: from localhost ([::1]:49070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvcmO-0006xz-Tx for qemu-devel@archiver.kernel.org; Fri, 10 Dec 2021 05:05:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvckl-00045B-Fa; Fri, 10 Dec 2021 05:03:47 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]:2911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvcki-0005Bk-32; Fri, 10 Dec 2021 05:03:47 -0500 Received: from dggeme706-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J9RHM5kBbz1DLHg; Fri, 10 Dec 2021 18:00:47 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by dggeme706-chm.china.huawei.com (10.1.199.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Fri, 10 Dec 2021 18:03:40 +0800 Received: from kwepemm600017.china.huawei.com ([7.193.23.234]) by kwepemm600017.china.huawei.com ([7.193.23.234]) with mapi id 15.01.2308.020; Fri, 10 Dec 2021 18:03:40 +0800 To: Richard Henderson , "qemu-devel@nongnu.org" , "qemu-riscv@nongnu.org" CC: "bin.meng@windriver.com" , "limingwang (A)" , "kvm@vger.kernel.org" , "libvir-list@redhat.com" , "anup.patel@wdc.com" , "wanbo (G)" , "Alistair.Francis@wdc.com" , "kvm-riscv@lists.infradead.org" , "Wanghaibin (D)" , "palmer@dabbelt.com" , "Fanliang (EulerOS)" , "Wubin (H)" Subject: RE: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization Thread-Topic: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization Thread-Index: AQHX3eLUE1sOoznHAU+RC9Ifd4t+hKwMe9AAgB8iu4A= Date: Fri, 10 Dec 2021 10:03:40 +0000 Message-ID: References: <20211120074644.729-1-jiangyifei@huawei.com> <20211120074644.729-13-jiangyifei@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.186.236] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.255; envelope-from=jiangyifei@huawei.com; helo=szxga08-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jiangyifei From: Jiangyifei via DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFJpY2hhcmQgSGVuZGVyc29u IFttYWlsdG86cmljaGFyZC5oZW5kZXJzb25AbGluYXJvLm9yZ10NCj4gU2VudDogU3VuZGF5LCBO b3ZlbWJlciAyMSwgMjAyMSA2OjM1IEFNDQo+IFRvOiBKaWFuZ3lpZmVpIDxqaWFuZ3lpZmVpQGh1 YXdlaS5jb20+OyBxZW11LWRldmVsQG5vbmdudS5vcmc7DQo+IHFlbXUtcmlzY3ZAbm9uZ251Lm9y Zw0KPiBDYzogYmluLm1lbmdAd2luZHJpdmVyLmNvbTsgbGltaW5nd2FuZyAoQSkgPGxpbWluZ3dh bmdAaHVhd2VpLmNvbT47DQo+IGt2bUB2Z2VyLmtlcm5lbC5vcmc7IGxpYnZpci1saXN0QHJlZGhh dC5jb207IGFudXAucGF0ZWxAd2RjLmNvbTsgd2FuYm8gKEcpDQo+IDx3YW5ibzEzQGh1YXdlaS5j b20+OyBBbGlzdGFpci5GcmFuY2lzQHdkYy5jb207DQo+IGt2bS1yaXNjdkBsaXN0cy5pbmZyYWRl YWQub3JnOyBXYW5naGFpYmluIChEKQ0KPiA8d2FuZ2hhaWJpbi53YW5nQGh1YXdlaS5jb20+OyBw YWxtZXJAZGFiYmVsdC5jb207IEZhbmxpYW5nIChFdWxlck9TKQ0KPiA8ZmFubGlhbmdAaHVhd2Vp LmNvbT47IFd1YmluIChIKSA8d3Uud3ViaW5AaHVhd2VpLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQ QVRDSCB2MSAxMi8xMl0gdGFyZ2V0L3Jpc2N2OiBTdXBwb3J0IHZpcnR1YWwgdGltZSBjb250ZXh0 DQo+IHN5bmNocm9uaXphdGlvbg0KPiANCj4gT24gMTEvMjAvMjEgODo0NiBBTSwgWWlmZWkgSmlh bmcgd3JvdGU6DQo+ID4gICBjb25zdCBWTVN0YXRlRGVzY3JpcHRpb24gdm1zdGF0ZV9yaXNjdl9j cHUgPSB7DQo+ID4gICAgICAgLm5hbWUgPSAiY3B1IiwNCj4gPiAgICAgICAudmVyc2lvbl9pZCA9 IDMsDQo+ID4gICAgICAgLm1pbmltdW1fdmVyc2lvbl9pZCA9IDMsDQo+ID4gKyAgICAucG9zdF9s b2FkID0gY3B1X3Bvc3RfbG9hZCwNCj4gPiAgICAgICAuZmllbGRzID0gKFZNU3RhdGVGaWVsZFtd KSB7DQo+ID4gICAgICAgICAgIFZNU1RBVEVfVUlOVFRMX0FSUkFZKGVudi5ncHIsIFJJU0NWQ1BV LCAzMiksDQo+ID4gICAgICAgICAgIFZNU1RBVEVfVUlOVDY0X0FSUkFZKGVudi5mcHIsIFJJU0NW Q1BVLCAzMiksIEBAIC0yMTEsNg0KPiA+ICsyMjEsMTAgQEAgY29uc3QgVk1TdGF0ZURlc2NyaXB0 aW9uIHZtc3RhdGVfcmlzY3ZfY3B1ID0gew0KPiA+ICAgICAgICAgICBWTVNUQVRFX1VJTlQ2NChl bnYubXRvaG9zdCwgUklTQ1ZDUFUpLA0KPiA+ICAgICAgICAgICBWTVNUQVRFX1VJTlQ2NChlbnYu dGltZWNtcCwgUklTQ1ZDUFUpLA0KPiA+DQo+ID4gKyAgICAgICAgVk1TVEFURV9VSU5UNjQoZW52 Lmt2bV90aW1lcl90aW1lLCBSSVNDVkNQVSksDQo+ID4gKyAgICAgICAgVk1TVEFURV9VSU5UNjQo ZW52Lmt2bV90aW1lcl9jb21wYXJlLCBSSVNDVkNQVSksDQo+ID4gKyAgICAgICAgVk1TVEFURV9V SU5UNjQoZW52Lmt2bV90aW1lcl9zdGF0ZSwgUklTQ1ZDUFUpLA0KPiA+ICsNCj4gPiAgICAgICAg ICAgVk1TVEFURV9FTkRfT0ZfTElTVCgpDQo+ID4gICAgICAgfSwNCj4gDQo+IENhbid0IGFsdGVy IFZNU3RhdGVEZXNjcmlwdGlvbi5maWVsZHMgd2l0aG91dCBidW1waW5nIHZlcnNpb24uDQo+IA0K PiBJZiB0aGlzIGlzIHJlYWxseSBrdm0tb25seSBzdGF0ZSwgY29uc2lkZXIgcGxhY2luZyBpdCBp bnRvIGEgc3Vic2VjdGlvbi4gIEJ1dCBJDQo+IHdvcnJ5IGFib3V0IGt2bS1vbmx5IHN0YXRlIGJl Y2F1c2UgaWRlYWxseSB3ZSdkIGJlIGFibGUgdG8gbWlncmF0ZSBiZXR3ZWVuDQo+IHRjZyBhbmQg a3ZtIChpZiBvbmx5IGZvciBkZWJ1Z2dpbmcpLg0KPiANCj4gDQo+IHJ+DQoNClRoYW5rcywgSSB3 aWxsIHVwZGF0ZSB0aGUgdmVyc2lvbiBpbiB0aGUgbmV4dCBzZXJpZXMgYW5kIHBsYWNlIGl0IGlu dG8gYSBzdWJzZWN0aW9uLg0KDQpZaWZlaQ0K