From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B22470E87 for ; Wed, 29 Jul 2026 11:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785323521; cv=none; b=NEkBDixs39ZApA9WOXWYA0xtcU9b/D/mwBxLoLG1UKIj3iOftRg2c1UFId1XSF9zMBYE6YGoGMqLqo7OVcSFWxiChp3HIB4Mbz8M6EBfXetg4y0Mtco+VI/NCyw0A6O+cGb5RaQC58igKlkFfC2bxOaHke22GlCo5ubRsZivGTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785323521; c=relaxed/simple; bh=F5TkoHP4ysYrGn2T9rCEX81ikt+BoCO5ZCcN6FhUTjk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YtIBtVYmA9V9eoSPfYC4L9SzjqpzgFolrn1z8dTWD/iDvP845bBkbDY7lAbYUYmGmAN73XDrcD+wlxUt+anDPDnFq7bgPBExQSL69OGi/FpCij7FFcv3ChQ6W7gfgxuPSwWmcUoNhcdL62xwmrTCG05JyOgpxILAcHtFmYd49uQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=frZl6kav; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ECkYNNgS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="frZl6kav"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ECkYNNgS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TB7HBI1788369 for ; Wed, 29 Jul 2026 11:11:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Fggnl1LDAh6PfDukmLgSUqpHpgc1JT1Q+oz06t1ZUfM=; b=frZl6kavX/PdVO/u 8S2CcwVNHu4hYa5dcnAxzX+fJjOGNzw9ZKUdHlVdnBBjnmcUMYoS5S/RmBAMVgdb 1tM2PEYv/SW/O4q18dl0BPObhKIccUZHOPCqsS2THjTpKloL/YY3VTaEp+kuUdNv SizF4LnEUSmacJeMZbOsYgbwmRmk1hjpyyb8C5PHaMl03ZwNtAHZPFy6HbyryuoR HNOKVRXrfu675+MeUqMvD4/cxn1GdKe4HpQBY9oG+a6UBx4P+BBxWLrePF/cyYnD NtscfJ9oWQS0ZawY2cxmUuO+lqoWdU83Dw/cUxMrdA2fePp5P5GV/7BAuiHEHPak 2B4qdA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqa331nwd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 11:11:58 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-9006b9c3fb6so1808916d6.2 for ; Wed, 29 Jul 2026 04:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785323517; x=1785928317; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fggnl1LDAh6PfDukmLgSUqpHpgc1JT1Q+oz06t1ZUfM=; b=ECkYNNgS3ztTBGyfsUnrUD7I3ufvK9yIjzvZVUwlryl4q9q3BD5OhzSW2aNgZRUE5b hwmJfJJ9wIJf2baT28VTdpj038AUyW0Tn0E2m+pkCBfDbjD5SHB4/VyNyyapzyCZePgX FPfdmKmcUmJk/zEqELll+YU+eP5P5WGLtjDfILksYzr/Pa8PFjsQLjolNZoHu6CR7ORb H6/hx4XsgIS36QXjtzxQuRZpCta+oy8IXxADk/C9vKNBKBDvCpinMhKcauN4GQZVQRq/ DmTjXyB3hsiSYeWpXo8OoIQTLpuaZKo2Gd9oWOWkUjv0KewTM2UFG6FVO3ij8EGbt6sU cuqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785323517; x=1785928317; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Fggnl1LDAh6PfDukmLgSUqpHpgc1JT1Q+oz06t1ZUfM=; b=drzoGmyL86CedQdoltUMrHmausoYyDv7X4BM/CvULxOKk2jYZ+HnfGGi54j1O7FWgh 5r44X3Mo7Z4VW3QoXu1u0ihubNnssKttUmDvoWfMSRV19PKN1eefsrFA4GO30qes+mv1 SVs5dVjMI6vzaymnVhHk/hfLXzVVfPoxau3SiCGc0pI+KFElB0gfcu8VsLwOh3GZIrU8 W1RcXJLjrtQHtvdUiO71UjfNHlzSupPHkqJRZjSTqAEES9IbzN1VCLjpBC9N1Bw1Dp/T QVEqEQw3GAcdwAALnxzHiTr6Khex50RFSBYwybcIXmhPfVa3IA7nw+IuLsUeR6jtMkLk lkLg== X-Forwarded-Encrypted: i=1; AHgh+RqZYWW7uUNWETrHO0KUf/iuUp1LRRQnl1URSQ5EuI9RrAO94Hinqfa13wUyqGNfMLnqP9XjWUVgBsZm2vEkigJx24Jb@vger.kernel.org X-Gm-Message-State: AOJu0YxtrOEA9dqZqwCQHaruxsggxQSqhhr8oY6Wkz+NqoCNU3xTmMvJ pJ+M0sU0SeuyIe6K9UeyxtY26z3IkgJUOM5DQqfo8Isymk4vraw6Y6GsQ12K3VHIxMBQSkdgusc zKD2aDWaY1cF1CVw8W2sCIog9gb8WJDc/AdDZav5SJ0NGYDoK+hy20Uk4vS5mSWvkoXNp7o9wqv FL X-Gm-Gg: AR+sD10U6jZWgDScQ990fodcoy2sKL1b6kbyw3/wa6HrHtHnStAJdWptGCSKgsEFWqM RvljWvBuJ/54Ym6p9gOizNBWe1ceZMOoYALfxfX2cI3o4lpUtS0OSElZi0o3p7F/AZ4G9kAefL1 i/F0tuH3QVFu3m8IGJ1ItwKylE6hdo3Avxzxjt8wFbRmnuBXdp50Z6acO+C/sjBVdvyBejRdPF4 xh/BZY6m3Egm5WLE7NxR/R+8OnJGm0hf2Lp1tfO2+QK5240+o6X7y9+FtRup4xzB8MBJN13Q6Ua QTFcjYt2VYzZ3avjzsQafROzoHmPkf2Z3TrfyH9u2ih4bfN2b7T4WNO/D5oLn+DxwZhvvKe9S4/ YkltY1H9yQ+gnea8vH3frlYPk X-Received: by 2002:a05:622a:15d5:b0:51b:ff78:f229 with SMTP id d75a77b69052e-529d6feaeabmr53202531cf.5.1785323517413; Wed, 29 Jul 2026 04:11:57 -0700 (PDT) X-Received: by 2002:a05:622a:15d5:b0:51b:ff78:f229 with SMTP id d75a77b69052e-529d6feaeabmr53202011cf.5.1785323516876; Wed, 29 Jul 2026 04:11:56 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1f83cde4dbsm101887966b.15.2026.07.29.04.11.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 04:11:56 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 13:11:53 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] platform: arm64: qcom-hamoa-ec: Retry I2C transfers on NACK To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-6-771abd65ee1a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260728-ec_add_more_commands-v1-6-771abd65ee1a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDA5MiBTYWx0ZWRfXwk3H0tOXNBnG t4D3qlZ1AqD+PHt8TPq7HXZvZiW1fvOIneDnqv8I2zGglssdrIFmzc+24JiRm2OnTg/75drMpVN A0f0iYS7PEtvMn1A2HPjgyJO26LWqgFUoo6XHRe1ABakFYv8ZM2r8Hewr5tLA9uHmMvI94zS63u MPLYjA3fdDzNmcC57Zk2tFMQwHATNkbbb/2It+uJvjJS2TlJRSdRoYwzOl0dpKkdZvMwmh+BUza YOhndjccX4phhi/xQtofrjzY8rMVjzHhtlWVGfJVrlROIxaMlBPnNEuio/5JyDpeEIQ6OyHfQ41 Ww8p4xXrkLrwh8N9phZ8lBQMJkgYhBTRKOWwt/oyumuv3IGGvGOg2Q+DscmbkjBXlfiWzuYCn7M aWtebUuHpB7GL6GPvakM2X9dTnO6lmMoy4rGRSwQl+j1BzY/2m8oFxYxhBnuqC7gITp6b9nRWCy iD92iuT9xQI0Lug15Uw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDA5MiBTYWx0ZWRfX2rI0YbeES3gu AwgUAxwvSnXotMVaa3NaWKfmACngU4bBdr0p+RMv1YDCj8hjhRoNm3ckzsRSPAkn3NiDS/c3PbU OjlGTih6F6T0ZuFZGV0qQBWqz+Bn0GI= X-Proofpoint-ORIG-GUID: tMI5EA3GSzWMefmKnBWycNSn1UaoKy1K X-Authority-Analysis: v=2.4 cv=Ap/eGu9P c=1 sm=1 tr=0 ts=6a69dffe cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=czGEQ3qvJAC79WJ7zqIA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: tMI5EA3GSzWMefmKnBWycNSn1UaoKy1K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290092 On 7/28/26 7:44 PM, Anvesh Jain P wrote: > The EC firmware NACKs the bus instead of clock-stretching while it is > busy servicing internal work (e.g. right after boot, when it is also > emitting a burst of SCI events). A transfer issued in that window fails > with -ENXIO even though the EC is otherwise healthy. > > This isn't visible with the smbus-only command set used previously; it > surfaced while stress-testing the new fan LUT command on Hamoa, which > issues raw i2c_transfer() calls more aggressively and is thus more > likely to land in the NACK window right after boot or during an SCI > event burst. > > Retry qcom_ec_write() and qcom_ec_read() a bounded number of times with > a short delay when the EC NACKs the transfer, before giving up. > > Signed-off-by: Anvesh Jain P > --- [...] > enum qcom_ec_sci_events { > EC_FAN1_STATUS_CHANGE_EVT = 0x30, > EC_FAN2_STATUS_CHANGE_EVT, > @@ -233,11 +245,20 @@ static int qcom_ec_write(struct qcom_ec *ec, u8 cmd, const u8 *data, size_t len) > msg.buf[0] = cmd; > memcpy(&msg.buf[1], data, len); > > - ret = i2c_transfer(ec->client->adapter, &msg, 1); > + for (int i = 0; i < EC_I2C_NACK_MAX_ATTEMPTS; i++) { > + ret = i2c_transfer(ec->client->adapter, &msg, 1); > + ret = ret == 1 ? 0 : (ret < 0 ? ret : -EIO); Please break this monster up. I know it already exists in-tree, but since you're moving it around, we might as well. Konrad