From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFE28C3DA41 for ; Thu, 11 Jul 2024 11:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f0rhphG7ahID31EvWyRr2DxZOlXKDEQjJhtx4/zuYcM=; b=lEM51WfaicSFsy f489LHEwTq9jGciPTcy0tuW42Nwb9ptpUjzFKu5w9WEEQja8046IoRT9CIwvc0LgPQkaSSgOIlXwX mjosCsaaXxNQOkOkcwo+WjFjUrwV/YyphNSgdh8nhzVn0MvwDL6itsQ/itZMj+Oydh3cN09JrPc62 xnTs3SSdXBDp6lrOIhvJ0lU1Eq/YGUMm7tGZ2mpKPPIM+ouEOX8lrBnxSzg01uS9pzeIJxtYplRnw A7fomthL1dVHVXdctlhYFGG1n4Fe3RKKxyDerZsk5iKyWLt4VFB5NSaQJCnKKYCYiaNqe82ZEe+dZ pQBCZo0XffxYPT7ICTew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRrkC-0000000DhQA-3TU1; Thu, 11 Jul 2024 11:13:48 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRrju-0000000DhKD-00eM; Thu, 11 Jul 2024 11:13:31 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-58b447c51bfso888441a12.2; Thu, 11 Jul 2024 04:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720696408; x=1721301208; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TYllvDYy8q+oSmnbTdjDBVB3IGKqLELFE6rlt3KjtiY=; b=XDzElEJrkl9NLRI8lIv8LUxuxvFSnYfQH3p+R94qJmLXKqvYRh3XaEnvTlebIyF78A BSGhxtDGHApXnLnELQgd3z36955yMJzX0xUts70rj9gm1i8Rm6yiiRGqfPuCANeXtNiV NNWS6bkvYjcBKaxuyxD05oBBur0Fh16oYzZIPL1DHbRs/VY6XLC10IkFuJGIJHYX2zFX rqX8+VXCPNPnCAU/3NJJBrVJnx6yUEtJwYQ+LLc/XoD0ockyMSD0kgtc8+qfeajfbvYN 89/N0xItE2+MZFqofuGiW2rAAi60DxRS1bs+dmrYUZkek8+t+AqHVbmJCyrnUR7rr8Eu Ecpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720696408; x=1721301208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TYllvDYy8q+oSmnbTdjDBVB3IGKqLELFE6rlt3KjtiY=; b=Xo9csYUeo/FfgT/e+5r9UAi/sjJK7TSjj1F6q3SaS6ARejkp9jwkAjDIrCa4PitQR8 87guvolTbRL1BcWFjc9cOYN1j/leUlqS8kypZBVZ0gsiEq2o6Le1WdiL8QguVUtwZTwu gQ9fuz78jLvjzQpv+hz1Y0HibxpajtboDXON0/0oVjzsf8hwr5sY9ICv61aH7TESEYD2 zmbZr38vakwZRH9DuFEJnBJjItJSbNrJ9i4KXKo76IE5mN2c+jzw+LYiiTclYCDNU9i/ 9UlyITC9egWeGGrRLFaFbPUSjQtCsVxiaKOD8DJ2CQmU+xz4aXlNwYmLUc/7EDlFcE2u lpSQ== X-Forwarded-Encrypted: i=1; AJvYcCVJg9HBlAZmlEXfuPNuBn9L53DXqbVUURkJC+BW9X4bUOz62bCaSW0ATSqDSwiZd/JblIutkluf4o3jrQuqZPRd8bIpVsvdQu6BB9dET3v35nw6RdIfxvExprSq+qwDBtUuNOWl7n6OyM9ceqc2MoqSXm+M8Jbj+wY= X-Gm-Message-State: AOJu0YytoeFaX/YPih7hcaVlSncJJh2loAOs4J74KLpu0ZBpwnW6f2o1 sEfZCB6H2dtPIXm/1AZskvI6lv3N45wydbUzXJGyusuwJTt1pts= X-Google-Smtp-Source: AGHT+IGonB+tlK1s3YxPGzmQfLKujuweNBArj336FWhMTOeocRhQSO/drBcmCkcDCewxEfe4XLuMcw== X-Received: by 2002:a05:6402:1d13:b0:58f:90e0:a1d0 with SMTP id 4fb4d7f45d1cf-594bcab0311mr4576922a12.39.1720696407735; Thu, 11 Jul 2024 04:13:27 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:ce43:28ef:7742:f662? ([2a02:810b:f40:4600:ce43:28ef:7742:f662]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bc3f338fsm3371627a12.43.2024.07.11.04.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 04:13:27 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 13:13:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: rockchip: Add missing pinctrl for PCIe30x4 node To: wens@kernel.org, Jonas Karlman , Heiko Stuebner Cc: Anand Moon , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240711060939.1128-1-linux.amoon@gmail.com> Content-Language: en-US From: Alex Bee In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_041330_065004_0BD8544E X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gMTEuMDcuMjQgdW0gMTE6MTcgc2NocmllYiBDaGVuLVl1IFRzYWk6Cj4gT24gVGh1LCBKdWwg MTEsIDIwMjQgYXQgNDo0NOKAr1BNIEpvbmFzIEthcmxtYW4gPGpvbmFzQGt3aWJvby5zZT4gd3Jv dGU6Cj4+Cj4+IEhpIEFuYW5kLAo+Pgo+PiBPbiAyMDI0LTA3LTExIDA4OjA5LCBBbmFuZCBNb29u IHdyb3RlOgo+Pj4gQWRkIG1pc3NpbmcgcGluY3RybCBzZXR0aW5ncyBmb3IgUENJZSAzLjAgeDQg Y2xvY2sgcmVxdWVzdCBhbmQgd2FrZQo+Pj4gc2lnbmFscy5FYWNoIGNvbXBvbmVudCBvZiBQQ0ll IGNvbW11bmljYXRpb24gaGF2ZSB0aGUgZm9sbG93aW5nIGNvbnRyb2wKPj4+IHNpZ25hbHM6IFBF UlNULCBXQUtFLCBDTEtSRVEsIGFuZCBSRUZDTEsuIFRoZXNlIHNpZ25hbHMgd29yayB0byBnZW5l cmF0ZQo+Pj4gaGlnaC1zcGVlZCBzaWduYWxzIGFuZCBjb21tdW5pY2F0ZSB3aXRoIG90aGVyIFBD SWUgZGV2aWNlcy4KPj4+IFVzZWQgYnkgcm9vdCBjb21wbGV4IHRvIGVuZHBvaW50IGRlcGVuZGlu ZyBvbiB0aGUgcG93ZXIgc3RhdGUuCj4+Pgo+Pj4gUEVSU1QgaXMgcmVmZXJyZWQgdG8gYXMgYSBm dW5kYW1lbnRhbCByZXNldC4gUEVSU1Qgc2hvdWxkIGJlIGhlbGQgbG93Cj4+PiB1bnRpbCBhbGwg dGhlIHBvd2VyIHJhaWxzIGluIHRoZSBzeXN0ZW0gYW5kIHRoZSByZWZlcmVuY2UgY2xvY2sgYXJl IHN0YWJsZS4KPj4+IEEgdHJhbnNpdGlvbiBmcm9tIGxvdyB0byBoaWdoIGluIHRoaXMgc2lnbmFs IHVzdWFsbHkgaW5kaWNhdGVzIHRoZQo+Pj4gYmVnaW5uaW5nIG9mIGxpbmsgaW5pdGlhbGl6YXRp b24uCj4+Pgo+Pj4gV0FLRSBzaWduYWwgaXMgYW4gYWN0aXZlLWxvdyBzaWduYWwgdGhhdCBpcyB1 c2VkIHRvIHJldHVybiB0aGUgUENJZQo+Pj4gaW50ZXJmYWNlIHRvIGFuIGFjdGl2ZSBzdGF0ZSB3 aGVuIGluIGEgbG93LXBvd2VyIHN0YXRlLgo+Pj4KPj4+IENMS1JFUSBzaWduYWwgaXMgYWxzbyBh biBhY3RpdmUtbG93IHNpZ25hbCBhbmQgaXMgdXNlZCB0byByZXF1ZXN0IHRoZQo+Pj4gcmVmZXJl bmNlIGNsb2NrLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEFuYW5kIE1vb24gPGxpbnV4LmFtb29u QGdtYWlsLmNvbT4KPj4+IC0tLQo+Pj4gVjI6IFVwZGF0ZSB0aGUgY29tbWl0IG1lc3NnZSB0byBk ZXNjcmliZSB0aGUgY2hhbmdzLgo+Pj4gICAgICB1c2UgcGluY3RsIGdyb3VwIGFzIGl0cyBwcmUg ZGVmaW5lIGluIHBpbmN0bCBkdHNpCj4+PiAtLS0KPj4+ICAgYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazM1ODgtcm9jay01Yi5kdHMgfCA2ICstLS0tLQo+Pj4gICAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDUgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzIGIvYXJjaC9hcm02 NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgtcm9jay01Yi5kdHMKPj4+IGluZGV4IDJlNzUxMjY3 NmI3ZS4uYWIzYTIwOTg2YzZhIDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazM1ODgtcm9jay01Yi5kdHMKPj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzCj4+PiBAQCAtMzAxLDcgKzMwMSw3IEBAICZwY2ll MzBwaHkgewo+Pj4KPj4+ICAgJnBjaWUzeDQgewo+Pj4gICAgICAgIHBpbmN0cmwtbmFtZXMgPSAi ZGVmYXVsdCI7Cj4+PiAtICAgICBwaW5jdHJsLTAgPSA8JnBjaWUzX3JzdD47Cj4+PiArICAgICBw aW5jdHJsLTAgPSA8JnBjaWUzMHg0bTFfcGlucz47Cj4+Cj4+IFVzZSBvZiB0aGUgZXhpc3Rpbmcg cGNpZTMweDRtMV9waW5zIGdyb3VwIG1heSBub3QgYmUgZnVsbHkgYWNjdXJhdGUgZm9yCj4+IHRo ZSBQRVJTVCBwaW4uIFRoZSB1c2Ugb2YgcmVzZXQtZ3Bpb3MgaW5kaWNhdGUgdGhhdCB0aGUgUEVS U1QgcGluIGlzCj4+IHVzZWQgd2l0aCBHUElPIGZ1bmN0aW9uIGFuZCB0aGUgZHJpdmVyIHdpbGwg aW1wbGljaXRseSBjaGFuZ2UgdGhlCj4+IGZ1bmN0aW9uIGZyb20gcGVyc3RuX20xIHRvIEdQSU8u IFNvIHRoaXMgbWF5IG5vdCBiZSBiZXN0IHJlcHJlc2VudGF0aW9uCj4+IG9mIHRoZSBodywgaGVu Y2UgbXkgaW5pdGlhbCBzdWdnZXN0aW9uLCBzb21ldGhpbmcgbGlrZToKPj4KPj4gICAgICAgICAg cGNpZTMweDRfcGluczogcGNpZTMweDQtcGlucyB7Cj4+ICAgICAgICAgICAgICAgICAgcm9ja2No aXAscGlucyA9Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICA8NCBSS19QQjQgNCAmcGNmZ19w dWxsX25vbmU+LAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgPDQgUktfUEI2IFJLX0ZVTkNf R1BJTyAmcGNmZ19wdWxsX25vbmU+LAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgPDQgUktf UEI1IDQgJnBjZmdfcHVsbF9ub25lPjsKPj4gICAgICAgICAgfTsKPj4KPj4gU2ltaWxhciBjaGFu Z2Ugc2hvdWxkIHByb2JhYmx5IGFsc28gYmUgZG9uZSBmb3IgcGNpZTJ4MWwwIGFuZCBwY2llMngx bDIsCj4+IG5vdCBqdXN0IHBjaWUzeDQuCj4gCj4gQ2FuIHdlIGNvbnNpZGVyIGltcGxlbWVudGlu ZyBzdHJpY3QgbW9kZSBpbiB0aGUgcGluY3RybCBkcml2ZXIgc28gd2UgZG9uJ3QKPiBoYXZlIHRv IGtlZXAgZG9pbmcgdGhpcyBHUElPICsgcGlubXV4IGRhbmNlPwo+IAoKVGhpcyBpcyBub3QgYWJv dXQgZHJpdmVycywgdGhpcyBpcyBEVCB3aGljaCBpcyBpbmRlcGVuZGVudCBmcm9tIGRyaXZlcnMu CkpvbmFzIGFuZCBJIGhhZCBkaXNjdXNzaW9uIHJlY2VudGx5IG9uIHUtYm9vdCBtYWlsaW5nIGxp c3Qgd2l0aCBzb21lYm9keQp1c2luZyBPcGVuL0ZyZWVCU0QgYWJvdXQgZXhhY3QgdGhhdCB0b3Bp Yy4gUGluY3RybCBtdXggc2V0dGluZ3Mgc2hvdWxkIGJlCnZlcnkgZXhwbGljaXQsIGV2ZW4gaWYg aXQgaXMgbm90IHJlcXVpcmVkIGJ5IHRoZSBsaW51eC1kcml2ZXIuCgpBbGV4Cgo+IENoZW5ZdQo+ IAo+IAo+PiBSZWdhcmRzLAo+PiBKb25hcwo+Pgo+Pj4gICAgICAgIHJlc2V0LWdwaW9zID0gPCZn cGlvNCBSS19QQjYgR1BJT19BQ1RJVkVfSElHSD47Cj4+PiAgICAgICAgdnBjaWUzdjMtc3VwcGx5 ID0gPCZ2Y2MzdjNfcGNpZTMwPjsKPj4+ICAgICAgICBzdGF0dXMgPSAib2theSI7Cj4+PiBAQCAt MzQxLDEwICszNDEsNiBAQCBwY2llMl8yX3JzdDogcGNpZTItMi1yc3Qgewo+Pj4gICAgICAgIH07 Cj4+Pgo+Pj4gICAgICAgIHBjaWUzIHsKPj4+IC0gICAgICAgICAgICAgcGNpZTNfcnN0OiBwY2ll My1yc3Qgewo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIHJvY2tjaGlwLHBpbnMgPSA8NCBSS19Q QjYgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+PiAtICAgICAgICAgICAgIH07Cj4+ PiAtCj4+PiAgICAgICAgICAgICAgICBwY2llM192Y2MzdjNfZW46IHBjaWUzLXZjYzN2My1lbiB7 Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgIHJvY2tjaGlwLHBpbnMgPSA8MSBSS19QQTQgUktf RlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+PiAgICAgICAgICAgICAgICB9Owo+Pj4KPj4+ IGJhc2UtY29tbWl0OiAzNGFmYjgyYTNjNjdmODY5MjY3YTI2ZjU5M2I2ZjhmYzZiZjM1OTA1Cj4+ Cj4+Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yb2NrY2hpcAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F7B1C3DA41 for ; Thu, 11 Jul 2024 11:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TYllvDYy8q+oSmnbTdjDBVB3IGKqLELFE6rlt3KjtiY=; b=gfR1NELwrW+KnqwoSzwstpMg5d AmMk/6AeLibg5BNNzEMveFl3tDHNDf+hTAxia0vcNwTqmQYF5F0O3omcti1xsK68PhrbOG4lig2zs 5sCycBAvDQ7A5oq5F/sHYoOdaHxR63wQrdlhqNmZoO8nZusL1eY7llx/7jZdfJf9GZdaDC2nb1Z3T 17bi5mf3H2+m4HMMsj5ORrQD11keOQu/l1QxOj14+OAd0k3u4BGhi/fVhtgDtiIw8ontCcQZKAx/H mpFWCupAckhj5zTG9nw6+5BGepifFR6cADKnuuw5qUmXhkfzRP5LEy4He5Lr05BVtZmPYTnbUT008 agVGPz7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRrkC-0000000DhPk-0gvl; Thu, 11 Jul 2024 11:13:48 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRrju-0000000DhKD-00eM; Thu, 11 Jul 2024 11:13:31 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-58b447c51bfso888441a12.2; Thu, 11 Jul 2024 04:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720696408; x=1721301208; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TYllvDYy8q+oSmnbTdjDBVB3IGKqLELFE6rlt3KjtiY=; b=XDzElEJrkl9NLRI8lIv8LUxuxvFSnYfQH3p+R94qJmLXKqvYRh3XaEnvTlebIyF78A BSGhxtDGHApXnLnELQgd3z36955yMJzX0xUts70rj9gm1i8Rm6yiiRGqfPuCANeXtNiV NNWS6bkvYjcBKaxuyxD05oBBur0Fh16oYzZIPL1DHbRs/VY6XLC10IkFuJGIJHYX2zFX rqX8+VXCPNPnCAU/3NJJBrVJnx6yUEtJwYQ+LLc/XoD0ockyMSD0kgtc8+qfeajfbvYN 89/N0xItE2+MZFqofuGiW2rAAi60DxRS1bs+dmrYUZkek8+t+AqHVbmJCyrnUR7rr8Eu Ecpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720696408; x=1721301208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TYllvDYy8q+oSmnbTdjDBVB3IGKqLELFE6rlt3KjtiY=; b=Xo9csYUeo/FfgT/e+5r9UAi/sjJK7TSjj1F6q3SaS6ARejkp9jwkAjDIrCa4PitQR8 87guvolTbRL1BcWFjc9cOYN1j/leUlqS8kypZBVZ0gsiEq2o6Le1WdiL8QguVUtwZTwu gQ9fuz78jLvjzQpv+hz1Y0HibxpajtboDXON0/0oVjzsf8hwr5sY9ICv61aH7TESEYD2 zmbZr38vakwZRH9DuFEJnBJjItJSbNrJ9i4KXKo76IE5mN2c+jzw+LYiiTclYCDNU9i/ 9UlyITC9egWeGGrRLFaFbPUSjQtCsVxiaKOD8DJ2CQmU+xz4aXlNwYmLUc/7EDlFcE2u lpSQ== X-Forwarded-Encrypted: i=1; AJvYcCVJg9HBlAZmlEXfuPNuBn9L53DXqbVUURkJC+BW9X4bUOz62bCaSW0ATSqDSwiZd/JblIutkluf4o3jrQuqZPRd8bIpVsvdQu6BB9dET3v35nw6RdIfxvExprSq+qwDBtUuNOWl7n6OyM9ceqc2MoqSXm+M8Jbj+wY= X-Gm-Message-State: AOJu0YytoeFaX/YPih7hcaVlSncJJh2loAOs4J74KLpu0ZBpwnW6f2o1 sEfZCB6H2dtPIXm/1AZskvI6lv3N45wydbUzXJGyusuwJTt1pts= X-Google-Smtp-Source: AGHT+IGonB+tlK1s3YxPGzmQfLKujuweNBArj336FWhMTOeocRhQSO/drBcmCkcDCewxEfe4XLuMcw== X-Received: by 2002:a05:6402:1d13:b0:58f:90e0:a1d0 with SMTP id 4fb4d7f45d1cf-594bcab0311mr4576922a12.39.1720696407735; Thu, 11 Jul 2024 04:13:27 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:ce43:28ef:7742:f662? ([2a02:810b:f40:4600:ce43:28ef:7742:f662]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bc3f338fsm3371627a12.43.2024.07.11.04.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 04:13:27 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 13:13:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: rockchip: Add missing pinctrl for PCIe30x4 node To: wens@kernel.org, Jonas Karlman , Heiko Stuebner Cc: Anand Moon , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240711060939.1128-1-linux.amoon@gmail.com> Content-Language: en-US From: Alex Bee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_041330_065004_0BD8544E X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 11.07.24 um 11:17 schrieb Chen-Yu Tsai: > On Thu, Jul 11, 2024 at 4:44 PM Jonas Karlman wrote: >> >> Hi Anand, >> >> On 2024-07-11 08:09, Anand Moon wrote: >>> Add missing pinctrl settings for PCIe 3.0 x4 clock request and wake >>> signals.Each component of PCIe communication have the following control >>> signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate >>> high-speed signals and communicate with other PCIe devices. >>> Used by root complex to endpoint depending on the power state. >>> >>> PERST is referred to as a fundamental reset. PERST should be held low >>> until all the power rails in the system and the reference clock are stable. >>> A transition from low to high in this signal usually indicates the >>> beginning of link initialization. >>> >>> WAKE signal is an active-low signal that is used to return the PCIe >>> interface to an active state when in a low-power state. >>> >>> CLKREQ signal is also an active-low signal and is used to request the >>> reference clock. >>> >>> Signed-off-by: Anand Moon >>> --- >>> V2: Update the commit messge to describe the changs. >>> use pinctl group as its pre define in pinctl dtsi >>> --- >>> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 6 +----- >>> 1 file changed, 1 insertion(+), 5 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> index 2e7512676b7e..ab3a20986c6a 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> @@ -301,7 +301,7 @@ &pcie30phy { >>> >>> &pcie3x4 { >>> pinctrl-names = "default"; >>> - pinctrl-0 = <&pcie3_rst>; >>> + pinctrl-0 = <&pcie30x4m1_pins>; >> >> Use of the existing pcie30x4m1_pins group may not be fully accurate for >> the PERST pin. The use of reset-gpios indicate that the PERST pin is >> used with GPIO function and the driver will implicitly change the >> function from perstn_m1 to GPIO. So this may not be best representation >> of the hw, hence my initial suggestion, something like: >> >> pcie30x4_pins: pcie30x4-pins { >> rockchip,pins = >> <4 RK_PB4 4 &pcfg_pull_none>, >> <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>, >> <4 RK_PB5 4 &pcfg_pull_none>; >> }; >> >> Similar change should probably also be done for pcie2x1l0 and pcie2x1l2, >> not just pcie3x4. > > Can we consider implementing strict mode in the pinctrl driver so we don't > have to keep doing this GPIO + pinmux dance? > This is not about drivers, this is DT which is independent from drivers. Jonas and I had discussion recently on u-boot mailing list with somebody using Open/FreeBSD about exact that topic. Pinctrl mux settings should be very explicit, even if it is not required by the linux-driver. Alex > ChenYu > > >> Regards, >> Jonas >> >>> reset-gpios = <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>; >>> vpcie3v3-supply = <&vcc3v3_pcie30>; >>> status = "okay"; >>> @@ -341,10 +341,6 @@ pcie2_2_rst: pcie2-2-rst { >>> }; >>> >>> pcie3 { >>> - pcie3_rst: pcie3-rst { >>> - rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; >>> - }; >>> - >>> pcie3_vcc3v3_en: pcie3-vcc3v3-en { >>> rockchip,pins = <1 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>; >>> }; >>> >>> base-commit: 34afb82a3c67f869267a26f593b6f8fc6bf35905 >> >> > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip