From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989F1C352A2 for ; Wed, 5 Feb 2020 15:18:12 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2DD3C22314 for ; Wed, 5 Feb 2020 15:18:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pk1qMj98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DD3C22314 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AEB2F4A7F1; Wed, 5 Feb 2020 10:18:11 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pFQIGNi547Nq; Wed, 5 Feb 2020 10:18:10 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BCE8E4A578; Wed, 5 Feb 2020 10:18:10 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 728834A51F for ; Wed, 5 Feb 2020 10:18:09 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qKnmPo-nGPHE for ; Wed, 5 Feb 2020 10:18:08 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4B7A24A4A0 for ; Wed, 5 Feb 2020 10:18:08 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DEF921927; Wed, 5 Feb 2020 15:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580915887; bh=NjMtCH7e1lEgkw+UMOfnxM45wLLuwDnPbf87CRI+yiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pk1qMj98DbqsrY9zinX98tPIosYlQDmFJUfNGjO3f6+6PUDmBrZ3KqEah87F3scC0 A1zO+7lBUSwfFGjGeEKJJwsFgqbdslcWmf+Hb9mMb3wLN0DG1KOztvq+G+MxaIkyjZ LVqEpHPTFP1i9aw0NG1O15O7yOs2MJCHGlvPwQ8o= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izMRJ-0039cd-Dy; Wed, 05 Feb 2020 15:18:05 +0000 MIME-Version: 1.0 Date: Wed, 05 Feb 2020 15:18:05 +0000 From: Marc Zyngier To: Jeremy Cline Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h In-Reply-To: <20200205134146.82678-1-jcline@redhat.com> References: <20200205134146.82678-1-jcline@redhat.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jcline@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2020-02-05 13:41, Jeremy Cline wrote: > Fedora kernel builds on armv7hl began failing recently because > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > trace.h. Add the missing include. > > Signed-off-by: Jeremy Cline > --- > > I've not dug very deeply into what exactly changed between commit > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > handling"). > > Fedora's build config is available at > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config This config doesn't have KVM enabled. > > virt/kvm/arm/trace.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > index 204d210d01c2..cc94ccc68821 100644 > --- a/virt/kvm/arm/trace.h > +++ b/virt/kvm/arm/trace.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM kvm After enabling KVM in the above config (which requires LPAE), I've managed to reproduce the problem. Fix now queued, thanks. M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE459C35247 for ; Wed, 5 Feb 2020 15:18:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF23621D7D for ; Wed, 5 Feb 2020 15:18:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZpnEdEe8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pk1qMj98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF23621D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QLAVVciW61Ahjglvc8eJludTifJHj/9epkHuHpVB3i8=; b=ZpnEdEe86XFlTcgvtfC8gqRSs OOxiQGTxnEDDMHrXCWY/8joEOWPJ3JmznBMN/ooCdXiWN7+K+6yDlF3znKMUQMZt5e7xCjTMQZd2a olqG4geenEK5cmVoaf+A+On7x3Knmu1bxKz5u1LWMeC48s5xSH4ACBs9+tLXnOCioF6655RubwFFO lPwK5magepZtOS6+UoSSdMy5iGrhXNYSPJ6iS5YzQB8K21T2WXogjTU0gVw7J1idmJgl1T9wMUUdO RfZay4qiDwHSjWxYP6XRKzKcMhKU+2T48wgtctpiWRAvnHUnqgoG+RLfXKpDDyaqi1LyprcHLMSng LhQfM2UCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izMRP-0001dJ-R8; Wed, 05 Feb 2020 15:18:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izMRM-0001cs-0x for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 15:18:09 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DEF921927; Wed, 5 Feb 2020 15:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580915887; bh=NjMtCH7e1lEgkw+UMOfnxM45wLLuwDnPbf87CRI+yiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pk1qMj98DbqsrY9zinX98tPIosYlQDmFJUfNGjO3f6+6PUDmBrZ3KqEah87F3scC0 A1zO+7lBUSwfFGjGeEKJJwsFgqbdslcWmf+Hb9mMb3wLN0DG1KOztvq+G+MxaIkyjZ LVqEpHPTFP1i9aw0NG1O15O7yOs2MJCHGlvPwQ8o= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izMRJ-0039cd-Dy; Wed, 05 Feb 2020 15:18:05 +0000 MIME-Version: 1.0 Date: Wed, 05 Feb 2020 15:18:05 +0000 From: Marc Zyngier To: Jeremy Cline Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h In-Reply-To: <20200205134146.82678-1-jcline@redhat.com> References: <20200205134146.82678-1-jcline@redhat.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jcline@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_071808_087234_77D358B7 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , linux-kernel@vger.kernel.org, James Morse , Julien Thierry , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-02-05 13:41, Jeremy Cline wrote: > Fedora kernel builds on armv7hl began failing recently because > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > trace.h. Add the missing include. > > Signed-off-by: Jeremy Cline > --- > > I've not dug very deeply into what exactly changed between commit > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > handling"). > > Fedora's build config is available at > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config This config doesn't have KVM enabled. > > virt/kvm/arm/trace.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > index 204d210d01c2..cc94ccc68821 100644 > --- a/virt/kvm/arm/trace.h > +++ b/virt/kvm/arm/trace.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM kvm After enabling KVM in the above config (which requires LPAE), I've managed to reproduce the problem. Fix now queued, thanks. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C739C35247 for ; Wed, 5 Feb 2020 15:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 614AA21741 for ; Wed, 5 Feb 2020 15:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580916047; bh=NjMtCH7e1lEgkw+UMOfnxM45wLLuwDnPbf87CRI+yiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sG899fqdf1Y1rKN4yQDJC6wzqR+CqPe80C5vCMKOcDuCh9jyvTYQv/AjRUmwNRSDW 3+QvZbAOpQ629SMIaDMfO4rIvx07k0frRq8ehCj0K1kBzjhDwT4sgc3YZxppg2sxYA GaWu6gN+7ZqYC5njf1PyfVNO3Ppd25m5y+QZgO38= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbgBEPUq (ORCPT ); Wed, 5 Feb 2020 10:20:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:53676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbgBEPUq (ORCPT ); Wed, 5 Feb 2020 10:20:46 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DEF921927; Wed, 5 Feb 2020 15:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580915887; bh=NjMtCH7e1lEgkw+UMOfnxM45wLLuwDnPbf87CRI+yiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pk1qMj98DbqsrY9zinX98tPIosYlQDmFJUfNGjO3f6+6PUDmBrZ3KqEah87F3scC0 A1zO+7lBUSwfFGjGeEKJJwsFgqbdslcWmf+Hb9mMb3wLN0DG1KOztvq+G+MxaIkyjZ LVqEpHPTFP1i9aw0NG1O15O7yOs2MJCHGlvPwQ8o= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izMRJ-0039cd-Dy; Wed, 05 Feb 2020 15:18:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 05 Feb 2020 15:18:05 +0000 From: Marc Zyngier To: Jeremy Cline Cc: James Morse , Julien Thierry , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h In-Reply-To: <20200205134146.82678-1-jcline@redhat.com> References: <20200205134146.82678-1-jcline@redhat.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jcline@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-05 13:41, Jeremy Cline wrote: > Fedora kernel builds on armv7hl began failing recently because > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > trace.h. Add the missing include. > > Signed-off-by: Jeremy Cline > --- > > I've not dug very deeply into what exactly changed between commit > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > handling"). > > Fedora's build config is available at > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config This config doesn't have KVM enabled. > > virt/kvm/arm/trace.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > index 204d210d01c2..cc94ccc68821 100644 > --- a/virt/kvm/arm/trace.h > +++ b/virt/kvm/arm/trace.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM kvm After enabling KVM in the above config (which requires LPAE), I've managed to reproduce the problem. Fix now queued, thanks. M. -- Jazz is not dead. It just smells funny...