From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B3CC6FD18 for ; Wed, 29 Mar 2023 02:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjC2Cfc (ORCPT ); Tue, 28 Mar 2023 22:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjC2Cfb (ORCPT ); Tue, 28 Mar 2023 22:35:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3D232D4F; Tue, 28 Mar 2023 19:35:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BC1E61A3E; Wed, 29 Mar 2023 02:35:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4B3AC433D2; Wed, 29 Mar 2023 02:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057326; bh=MyEuYDkf+StM1Q+SSNOS6qHcmlP6pXJ84tsG+a+VYtI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=MpHaPOwjxk7af0XuvP347IXG2YhTqKdVHlpN3daFBHZs/FkFg6d3tkCtlbz4ylh9T /LcNRWdhXQJV2LbXfvQb25ihDzuvA6QDK7siWWdYFJTzg111MlMuptTQy0XJdSIEtY 58hmVFqa/Hvr7P+kWRj1FA/OIHcTYo32NWTkaPEo4dY7WIL3j3V70dSNtrDurMOV6U yUyYxxdiBqyV/Iztxgx6r1FaLa0k72LIsM9Kq5nRh88XCE/oWYt74hW044ApRaFH2+ ZeYyTo5JPyOPuWsNk3V2zXbaddwKPvCiXm3v1v0ihKWx7lI6+R7g3H0xAVjMKT/wDs daeCLDz6WPcPw== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-4-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-4-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 03/30] clk: xilinx: Drop if block with always false condition From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Michael Turquette , Michal Simek , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:35:24 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:14:45) > xvcu_remove() is only called for a device after after xvcu_probe() > completed successfully. In that case dev_set_drvdata() was called for > that device with a non-NULL parameter, so platform_get_drvdata() won't > return NULL and the if condition is never true. >=20 > Drop the if, preparing a conversion to make platform driver's remove > callback return void. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B398DC761AF for ; Wed, 29 Mar 2023 02:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Opx8u34Jc0oi/Pfo5F9lrLCSDo8HHnKDggGeFQD2VpI=; b=IbZ3r1eelBbYNH JS7IGvERLfKqAOMF5SwtOJvh7C5JPhteSVl0pK4aVj+8SgZBjJtS4j6BzJkCj7Ys3svKmBjAerb6r 8eYyHzo7ukJELRZcH2EWqo6FF2GkeDLRnz3bqgCVxliH7BI7d7H5gmA5a6hsoTa6hTvIJLPLp4hlG us6MstZORWChdBW3WL5qLFWRUiu7l7OuKzhOeVdgtVtak86uoS2Aif/b4C08l6ixvBLoS8haBWNmY 2AvVfbChj3V7IWt61HFP8k/dqOnN2mnFmD/7dSo4d8iguN8+JtWVMkIWyLSlKwIeJpPTve9E5k0O+ V+aMz+GuY1oPaQqmpdGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phLes-00GM7u-0Q; Wed, 29 Mar 2023 02:35:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phLeq-00GM7S-0P for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 02:35:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BC5161A3F; Wed, 29 Mar 2023 02:35:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4B3AC433D2; Wed, 29 Mar 2023 02:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057326; bh=MyEuYDkf+StM1Q+SSNOS6qHcmlP6pXJ84tsG+a+VYtI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=MpHaPOwjxk7af0XuvP347IXG2YhTqKdVHlpN3daFBHZs/FkFg6d3tkCtlbz4ylh9T /LcNRWdhXQJV2LbXfvQb25ihDzuvA6QDK7siWWdYFJTzg111MlMuptTQy0XJdSIEtY 58hmVFqa/Hvr7P+kWRj1FA/OIHcTYo32NWTkaPEo4dY7WIL3j3V70dSNtrDurMOV6U yUyYxxdiBqyV/Iztxgx6r1FaLa0k72LIsM9Kq5nRh88XCE/oWYt74hW044ApRaFH2+ ZeYyTo5JPyOPuWsNk3V2zXbaddwKPvCiXm3v1v0ihKWx7lI6+R7g3H0xAVjMKT/wDs daeCLDz6WPcPw== Message-ID: MIME-Version: 1.0 In-Reply-To: <20230312161512.2715500-4-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-4-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 03/30] clk: xilinx: Drop if block with always false condition From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Michael Turquette , Michal Simek , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:35:24 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_193528_201736_BC0E199F X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBVd2UgS2xlaW5lLUvDtm5pZyAoMjAyMy0wMy0xMiAwOToxNDo0NSkKPiB4dmN1X3Jl bW92ZSgpIGlzIG9ubHkgY2FsbGVkIGZvciBhIGRldmljZSBhZnRlciBhZnRlciB4dmN1X3Byb2Jl KCkKPiBjb21wbGV0ZWQgc3VjY2Vzc2Z1bGx5LiBJbiB0aGF0IGNhc2UgZGV2X3NldF9kcnZkYXRh KCkgd2FzIGNhbGxlZCBmb3IKPiB0aGF0IGRldmljZSB3aXRoIGEgbm9uLU5VTEwgcGFyYW1ldGVy LCBzbyBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YSgpIHdvbid0Cj4gcmV0dXJuIE5VTEwgYW5kIHRoZSBp ZiBjb25kaXRpb24gaXMgbmV2ZXIgdHJ1ZS4KPiAKPiBEcm9wIHRoZSBpZiwgcHJlcGFyaW5nIGEg Y29udmVyc2lvbiB0byBtYWtlIHBsYXRmb3JtIGRyaXZlcidzIHJlbW92ZQo+IGNhbGxiYWNrIHJl dHVybiB2b2lkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWlu ZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4gLS0tCgpBcHBsaWVkIHRvIGNsay1uZXh0CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==