From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 320FEFD065F for ; Wed, 11 Mar 2026 08:54:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DA9810E130; Wed, 11 Mar 2026 08:54:39 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 3786E10E130 for ; Wed, 11 Mar 2026 08:54:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65501165C; Wed, 11 Mar 2026 01:54:31 -0700 (PDT) Received: from [10.57.58.73] (unknown [10.57.58.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02CEA3F73B; Wed, 11 Mar 2026 01:54:35 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 08:54:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/panthor: Fix the "done_fence is initialized" detection logic To: Boris Brezillon , Liviu Dudau , =?UTF-8?Q?Adri=C3=A1n_Larumbe?= Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com, Nicolas Frattaroli , Tvrtko Ursulin , Philipp Stanner , =?UTF-8?Q?Christian_K=C3=B6nig?= References: <20260309124318.222902-1-boris.brezillon@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260309124318.222902-1-boris.brezillon@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 09/03/2026 12:43, Boris Brezillon wrote: > After commit 541c8f2468b9 ("dma-buf: detach fence ops on signal v3"), > dma_fence::ops == NULL can't be used to check if the fence is initialized. > Use dma_fence_was_initialized() instead. > > v2: > - Use dma_fence_was_initialized() instead of open-coding it > > Cc: Nicolas Frattaroli > Cc: Tvrtko Ursulin > Cc: Philipp Stanner > Cc: Christian König > Reported-by: Steven Price > Reported-by: Nicolas Frattaroli > Fixes: 541c8f2468b9 ("dma-buf: detach fence ops on signal v3") > Signed-off-by: Boris Brezillon Applied to drm-misc-next. Thanks, Steve > --- > drivers/gpu/drm/panthor/panthor_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..c15941ebe07a 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3915,7 +3915,7 @@ static void job_release(struct kref *ref) > if (job->base.s_fence) > drm_sched_job_cleanup(&job->base); > > - if (job->done_fence && job->done_fence->ops) > + if (dma_fence_was_initialized(job->done_fence)) > dma_fence_put(job->done_fence); > else > dma_fence_free(job->done_fence);