From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: encapsulate forcewake in dev_priv
Date: Tue, 13 Sep 2011 23:25:46 +0100
Message-ID: <e39f63$1i9epd@fmsmga002.fm.intel.com>
References: <1315951648-5380-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2CC329F4CC
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Sep 2011 15:25:50 -0700 (PDT)
In-Reply-To: <1315951648-5380-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 13 Sep 2011 15:07:28 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> I had this lying around and forgot to submit it. I feel it makes the
> forcewake stuff slightly cleaner, but this is only cosmetic.
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

I like it as it makes it clearer the capability we are testing for. But
when to use INTEL_INFO and when to set derived bits on dev_priv? That is
the question.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre